| Age | Commit message (Collapse) | Author |
|
|
|
|
|
All formulae are in taps now.
|
|
Update the report logic, since now all formulae are in the taps.
|
|
We don't need to migrate the tapped formulae from symlink-based to
directory-based structure any more.
Instead, we add core tap install check for `brew update-report` which
will be invoked by `brew update`.
|
|
Also make `Homebrew/homebrew` as an alias of this tap to keep
backward compatibility.
|
|
The API used (`Net::HTTP::Post`) does not handle basic authentication
credentials in the same way as `open` so fix both cases so they work.
Also, do some general usability tweaks to point out to people what could
be wrong with their tokens or credentials to help them debug.
Closes Homebrew/homebrew#50410.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
This can become handy when we separate core code and formulae. For
example, we could use `cd $(brew --repo homebrew/core)` to go to core
tap path.
Closes Homebrew/homebrew#50346.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
The idea is to let `scm/git` to handle all of git location resolution
throughout Homebrew codebase.
Closes Homebrew/homebrew#50116.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
This reverts commit 0b38f9b286bc61e2b2d2232f80ea8ebc5909fb07.
|
|
Fixes https://github.com/Homebrew/homebrew/issues/50131
This commit removes the error backtrace and improves the error message
if a bad regexp is passed to `brew search`.
Closes Homebrew/homebrew#50173.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
This reverts commit 7032591bd44a8f50aaa55574ac97cd5cb7261460 and
commit 946c6deb4b5168ad2ec15e62aa6e81181e9e246c.
|
|
|
|
Ref:
- http://www.w3.org/TR/xml/#charsets
- http://stackoverflow.com/a/14323524
Closes Homebrew/homebrew#50092.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#50067.
Signed-off-by: Andrew Janke <andrew@apjanke.net>
|
|
Running brew audit --strict --online on a formula with a GitHub
homepage/url would crash if HOMEBREW_NO_GITHUB_API is set because
GitHub.repository returns `nil` and the audit code assumes it always
returns a hash.
Closes Homebrew/homebrew#50054.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Fixes Homebrew/homebrew#49757
Closes Homebrew/homebrew#49775
Closes Homebrew/homebrew#49947.
Signed-off-by: Andrew Janke <andrew@apjanke.net>
|
|
Looks like the bintray publish_wait_for_secs was being ignored because the
content type wasn't being set, so it defaulted to x-www-form-urlencoded
instead of application/json.
Changes the timeout to 0 to preserve current non-blocking behavior, which
we want in case multiple formulae are being updated.
Closes Homebrew/homebrew#49951.
Signed-off-by: Andrew Janke <andrew@apjanke.net>
|
|
This needs to be `Homebrew $HOMEBREW_VERSION` so we can be adequately
filtered.
Closes Homebrew/homebrew#49961.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Users shouldn't need to fetch all of git history.
Closes Homebrew/homebrew#49903.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
This reverts commit 0525c9eeea27eff1a6de05e7a01ec268ae07437b.
Which breaks `brew update --rebase`.
|
|
As requested in Homebrew/homebrew#46578. Falls back to existing functionality.
Closes Homebrew/homebrew#46578.
Closes Homebrew/homebrew#49846.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
|
|
Per document:
> -f, --force
> When git fetch is used with <rbranch>:<lbranch> refspec, it refuses
> to update the local branch <lbranch> unless the remote branch
> <rbranch> it fetches is a descendant of <lbranch>. This option
> overrides that check.
|
|
|
|
If it's not a tap, we test formula on CoreTap. This can happen
if we run test on a fork, e.g. Linuxbrew or future Homebrew/brew.
Closes Homebrew/homebrew#49844.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Instead of hard coded `Homebrew/homebrew`
|
|
Core tap will be separated from core code in the near future.
It makes sense to rename it to CoreTap.
|
|
Closes Homebrew/homebrew#49620.
|
|
Closes Homebrew/homebrew#49551.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
formula_rename and tap_migrations are now handled inside Tap.
Closes Homebrew/homebrew#49549.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#49523.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
* Better variable/class name. `update-report` isn't response to actual
update.
* Use abstraction offered by Reporter and ReproterHub class.
* Failure on one tap won't affect migration preformed by other taps.
* Simplify logic and prepare for core/formula separation.
|
|
* Better variable/class name.
* Remove obsolete update_renamed, this is now handled inside each
reporter.
* Remove obsolete formula file path to name computation, which is also
handled by reporter.
* Hide low lever implementation detail to offer better abstraction.
Use `add(reporter)` instead of `Hash#update` to add new report.
|
|
* Avoid tons of unnecessary file path manipulation. Use abstraction
offered by Tap class if possible.
* Handle formula rename/tap migration inside reporter in per tap basis.
* Avoid duplicated computation.
* Remove redundant/dead code.
|
|
Recently added files polluting brew ls --unbrewed results.
Closes Homebrew/homebrew#49456.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
When there are merge conflicts we fail pretty hard. This is still
possible after this commit but at least we've given Git enough pointers
to make it less likely.
Closes Homebrew/homebrew#49299.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Fixes Homebrew/homebrew#49334.
Closes Homebrew/homebrew#49343.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
This should help to prevent situations where a user accidentally ends up
"stranded" in a branch indefinitely.
Additionally, the stash is never popped automatically at the end of a
successful update, but the stash-pop message is printed if something is
stashed.
When an interrupt occurs, the original behavior is still in place
(switch back to the old branch and revision, and pop the stash), though
this could be changed as well.
This commit modifies the behavior of both `brew update` and
"update-bash.sh" in the manner described above.
The idea for this approach is from Mike McQuaid.
Issue Homebrew/homebrew#48812
Closes Homebrew/homebrew#48993.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Check to see if `HEAD` is the same as what we have locally. If it is:
don't bother to `git fetch`.
Closes Homebrew/homebrew#47888.
Closes Homebrew/homebrew#49219.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Return true if given path would present a Formula file in this Tap.
Accepts both absolute path and relative path (relative to this Tap's path)
It offer an abstraction such that caller would not need to worry about
low level file system in the tap.
It will be used in `brew pull` and `brew update`.
Closes Homebrew/homebrew#49191.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Also, rename the existing updater to `update-ruby` to allow using as
a fallback. It will eventually be removed.
Closes Homebrew/homebrew#49109.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#49084.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
Closes Homebrew/homebrew#49107.
Closes Homebrew/homebrew#49105.
Closes Homebrew/homebrew#48267.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
We execute too many `git fetch` at once for this to be useful. Just let
them fail instead and make it up to users to setup username/password
caching or SSH agents.
|
|
Closes Homebrew/homebrew#48472.
Signed-off-by: Andrew Janke <andrew@apjanke.net>
|
|
Closes Homebrew/homebrew#48706.
|
|
Also set atime to mtime, which seems to be a more common practice.
Fixes Homebrew/homebrew#49007
Closes Homebrew/homebrew#49027.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
We allow certain special regex characters in formula names, and if
those aren't escaped when interpolating them into a regex, they'll be
interpreted as special regex characters.
This can cause regex compile errors on Ruby 1.8 (for example, with
"libxml++3", which has nested match characters), and more subtle
matching bugs in general.
Refs an issue surfaced in Homebrew/homebrew#48744.
Closes Homebrew/homebrew#49005.
Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
|