aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2017-11-03requirement: don't add /usr/local/{bin,sbin}.Mike McQuaid
This should be considered a requirement bug if it's added.
2017-11-03requirement: prepend rather than append PATH.Mike McQuaid
Otherwise this ends up behind e.g. `/usr/bin` so is pretty useless.
2017-11-03bump-formula-pr: --message: add newlines before and after hrZhiming Wang
Without an empty line before the horizontal rule (---), "Created with `brew bump-formula-pr`." is treated as a setext header. The newline before the hr is not part of the heredoc because putting it in would trip up Rubocop.
2017-11-03Merge pull request #3389 from amyspark/hacktoberfest-single-zapMarkus Reiter
Check that a single uninstall_* and zap stanza is defined
2017-11-03Cask doctor: add macOS & Java versionscommitay
2017-11-02Merge pull request #3414 from ilovezfs/safe-navigationilovezfs
formula: fix safe navigation bug
2017-11-02formula: fix safe navigation bugilovezfs
Safe navigation needs to be chained to preserve equivalence. Fixes a bug introduced by 01e9ec9a in #3183.
2017-11-02Fix last remaining style issuesL. E. Segovia
2017-11-01Turn ifs into multiple linesL. E. Segovia
2017-11-01formula_desc_cop: Fix the 'full stop at end of description' autocorrectIsabell Long
- It wasn't working because desc strings end in quotes, not just full stops.
2017-11-01formula_desc_cop: If desc ends with 'etc.', it's not a violationIsabell Long
2017-11-01doc/Xcode: update for Xcode 9.1 releaseDominyk Tiller
2017-11-01xcode: expect Xcode 9.1 on Sierra & High SierraDominyk Tiller
2017-11-01mac: update for Xcode 9.1Dominyk Tiller
2017-10-31Capitalized wordsHassan F
Capitalized beginning of each bullet point to match style of README.md
2017-10-31xquartz: mark 2.7.11 as latest releaseDominyk Tiller
2017-10-31xquartz: add 2.7.10 & 2.7.11 releasesDominyk Tiller
2017-10-31Separate do end into multiple linesL. E. Segovia
2017-10-31Merge pull request #3362 from reitermarkus/system-commandMarkus Reiter
Fix `SystemCommand` without arguments.
2017-10-30Finalize metadata handling and uninstall logicL. E. Segovia
2017-10-31text_cop_spec: update go get testsDominyk Tiller
2017-10-31text_cop: warn against go_resource usage for strict auditDominyk Tiller
2017-10-31text_cop: drop go_resource recommendationDominyk Tiller
2017-10-30Add tests for uninstall_* and zap stanzasL. E. Segovia
2017-10-30Use #count, rewrite warning, and add pre/postflight checks tooL. E. Segovia
2017-10-30Fix `SystemCommand` without arguments.Markus Reiter
2017-10-30Merge pull request #3387 from MikeMcQuaid/env-std-homebrew-pathsMike McQuaid
ENV/std: fully extend from HOMEBREW_PATH.
2017-10-30Merge pull request #3398 from MikeMcQuaid/hub-no-browseMike McQuaid
bump-formula-pr: add --no-browse option.
2017-10-30bump-formula-pr: add --no-browse option.Mike McQuaid
If `--no-browse` is passed, don't pass the `--browse` argument to `hub` which opens the pull request URL in a browser. Instead, output it to the command line.
2017-10-30Merge pull request #3393 from MikeMcQuaid/with_env_tweaksMike McQuaid
Tweak use of with_env
2017-10-29Hack a first working version of upgradeL. E. Segovia
2017-10-29Merge pull request #3394 from MikeMcQuaid/sh-no-ps1Mike McQuaid
cmd/sh: set working PS1 for zsh
2017-10-29lines_cop: Update regex patterns to prevent false positivesGautham Goli
2017-10-29cmd/sh: set working PS1 for zsh.Mike McQuaid
The `bash`, default one is broken on `zsh`.
2017-10-29Merge pull request #3376 from tomjonandy/fix/keychain-credentialsMike McQuaid
Fix issue where keychain github credentials wouldn't work
2017-10-29Merge pull request #2795 from issyl0/desc_no_full_stopsMike McQuaid
formula_desc_cop: ensure no full stops at the end of desc
2017-10-29formula_desc_cop: ensure no full stops at the end of descIsabell Long
- This was a suggestion by Mike McQuaid in my `homebrew-core` audit description PR. Based on ilovezfs's incantation `grep -r -E 'desc ".*\."' *.rb`, some formulae descriptions do end in full stops. (My initial assessment of this failed to account for the fact that descriptions are strings and so end in `"`.) - Add an autocorrect for this cop, too.
2017-10-29Tweak use of with_envMike McQuaid
- Use it in more places where it saves code - Allow using symbolic keys for a cleaner interface - Use `HOMEBREW_GEM_*` instead of `GEM_OLD_*`
2017-10-29ENV/std: fully extend from HOMEBREW_PATH.Mike McQuaid
Rather than just re-adding HOMEBREW_PREFIX/bin if it's missing re-add everything from HOMEBREW_PATH. This works well with or without environment filtering being enabled but with environment filtering it ensures that ENV/std just builds on the original user environment.
2017-10-29Merge pull request #3388 from MikeMcQuaid/bump-formula-pr-env-filteringMike McQuaid
bump-formula-pr: always use HOMEBREW_PATH.
2017-10-29Merge pull request #3386 from MikeMcQuaid/config-homebrew-pathMike McQuaid
system_config: get perl/ruby from HOMEBREW_PATH.
2017-10-28Check that a single uninstall_* and zap stanzas is definedL. E. Segovia
2017-10-28bump-formula-pr: always use HOMEBREW_PATH.Mike McQuaid
Fixes this when using environment filtering.
2017-10-28system_config: get perl/ruby from HOMEBREW_PATH.Mike McQuaid
This is the actual user path when env filtering is enabled.
2017-10-28Merge pull request #3380 from jmsundar/apfs_tap-infoMike McQuaid
tap-info: handle APFS returning hash order
2017-10-28style changesJayendra Minakshisundar
2017-10-27Merge pull request #3381 from iMichka/flockMike McQuaid
lock.sh: suppress error output when looking for flock
2017-10-27Merge pull request #3382 from MikeMcQuaid/lines_cop_clang++Mike McQuaid
lines_cop: add missing e.g. clang++ regex SOL.
2017-10-27lines_cop: add missing e.g. clang++ regex SOL.Mike McQuaid
You need a start of line check in this regex (like was added in the others) to allow things like `#{bin}/clang++`.
2017-10-27lock.sh: suppress error output when looking for flockMichka Popoff
Fixes (on centos6): which: no flock in (/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)