aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2017-05-15Merge pull request #2631 from GauthamGoli/audit_homepage_rubocop1.2.1Mike McQuaid
audit: Port audit_homepage method to rubocop and add tests
2017-05-15Merge pull request #2628 from GauthamGoli/formula_desc_cop_fixMike McQuaid
audit: Detect multiline and interpolated strings in formula desc cop
2017-05-14Merge pull request #2635 from MikeMcQuaid/no-set-blank-varsMike McQuaid
bin/brew: don't set blank HOMEBREW_* variables.
2017-05-14bin/brew: don't set blank HOMEBREW_* variables.Mike McQuaid
When creating the necessary HOMEBREW_* variables ensure that they aren't set if their value would be empty.
2017-05-14Port audit_homepage method to rubocop and add testsGautham Goli
2017-05-14Merge pull request #2632 from MikeMcQuaid/sassMike McQuaid
docs.brew.sh: use SCSS.
2017-05-14Merge pull request #2627 from MikeMcQuaid/audit-fix-option-detectionMike McQuaid
audit: fix dependency option detection.
2017-05-14Merge pull request #2621 from MikeMcQuaid/rubocop-module-lengthMike McQuaid
rubocop: don't always care about module length.
2017-05-14Merge pull request #2620 from MikeMcQuaid/more-env-filtering-tweaksMike McQuaid
More environment filtering tweaks
2017-05-14Merge pull request #2619 from MikeMcQuaid/more-audit-versioned-aliasesMike McQuaid
audit: more checks for versioned aliases.
2017-05-14Merge pull request #2617 from MikeMcQuaid/interactive-home-accessMike McQuaid
Allow --interactive to access HOME
2017-05-14Merge pull request #2616 from MikeMcQuaid/devel-opt-aliasesMike McQuaid
keg: skip opt versioned aliases for devel/head.
2017-05-14docs.brew.sh: use SCSS.Mike McQuaid
Import style changes from: https://github.com/Homebrew/homebrew.github.io/pull/166
2017-05-14Merge pull request #2630 from iMichka/patch-1Mike McQuaid
Update to venv.pip_install_and_link in doc
2017-05-14Merge pull request #2610 from GauthamGoli/audit_components_autocorrectMike McQuaid
Add autocorrect method for ComponentsOrder rubocop and tests
2017-05-13Update to venv.pip_install_and_link in docMichka Popoff
`venv.link_scripts(bin) { venv.pip_install buildpath }` is now `venv.pip_install_and_link buildpath`
2017-05-13Update string_content method to support multiline strings, add test for sameGautham Goli
2017-05-13audit: fix dependency option detection.Mike McQuaid
Instead of trying to do this all with a single regex give up and do a two stage process. Eventually I'll end up implementing a full ruby parser here :troll:.
2017-05-13More environment filtering tweaksMike McQuaid
- only document HOMEBREW_* variables in the manpage (although still read from all the original environment variables). - resort manpage environment variables in alphabetical order - check the original path for trailing slashes
2017-05-13Add autocorrect method for ComponentsOrder rubocop and testsGautham Goli
2017-05-10Merge pull request #2615 from mansimarkaur/stat.mode_change_assertionMike McQuaid
diagnostic_spec.rb: assertion in check_access_lock_dir test
2017-05-10Merge pull request #2618 from MikeMcQuaid/issue-troubleshooting-tweaksMike McQuaid
Tweak troubleshooting docs and issue template
2017-05-10diagnostic_spec.rb: check_access_lock_dir testmansimarkaur
Added assertion to check `HOMEBREW_LOCK_DIR.stat.mode` changes after `HOMEBREW_LOCK_DIR.chmod 0555`
2017-05-09Allow --interactive to access HOMEMike McQuaid
This may result in a slightly varied build but it’s generally just far less annoying to be able to access all your e.g. shell configuration.
2017-05-09Tweak troubleshooting docs and issue templateMike McQuaid
- Note that Homebrew Cask issues should be filed elsewhere. - Make `brew`/homebrew-core issue differential in simpler language - Tell people to fix all `brew doctor` issues - Refer to the issue checklist and make it even more clear and prominent that we may close it out immediately if they don't use it. - Note that proposed new issues should be widely relevant. - Don't tell people they need to `brew cask install java`; we handle this in most places with a Java requirement and probably want issues filed where we don't. - Remove reference to Homebrew Dupes and replace with reference to Homebrew Cask to try and get people filing stuff there instead. Fixes #2608
2017-05-09keg: skip opt versioned aliases for devel/head.Mike McQuaid
These versioned aliases don’t correspond to the correct version if not Installed from stable. Fixes #2596.
2017-05-09audit: more checks for versioned aliases.Mike McQuaid
Check that a required versioned alias has a valid name (rather than assuming it’s fine based on it’s existence alone) and check for the presence of invalid version aliases. This should handle the case where someone bumps a formula but forgets to rename the alias that’s mentioned in #2596.
2017-05-09rubocop: don't always care about module length.Mike McQuaid
We don't care about this in external taps as this is more about code architecture than code style.
2017-05-08Merge pull request #2607 from MikeMcQuaid/travis-ci-tweaks-2Mike McQuaid
Travis CI tweaks.
2017-05-08Travis CI tweaks.Mike McQuaid
Attempt to improve Travis CI. This time without any vendoring gems nonsense.
2017-05-07Merge pull request #2591 from retokromer/patch-1Mike McQuaid
fix date-based versioning
2017-05-07Merge pull request #2606 from MikeMcQuaid/revert-vendor-gemsMike McQuaid
Revert gem vendoring experiment.
2017-05-07Revert "Merge pull request #2597 from MikeMcQuaid/vendor-gems"Mike McQuaid
This reverts commit 3e4547f52e7ebec633f8bfefc8a396d944edf908, reversing changes made to 6edf9382bcc1240ad6f97c8b752cfe56cef9965d.
2017-05-07Revert "Merge pull request #2603 from MikeMcQuaid/tweak-gem-vendoring"Mike McQuaid
This reverts commit 2372872974d1049c2beafe7dedb7f8f882502058, reversing changes made to 3e4547f52e7ebec633f8bfefc8a396d944edf908.
2017-05-07Revert "Merge pull request #2602 from MikeMcQuaid/travis-ci-tweaks"Mike McQuaid
This reverts commit 8d948e4b0b55912c592d34cb5ea83c649b1f9d5e, reversing changes made to 2372872974d1049c2beafe7dedb7f8f882502058.
2017-05-07Merge pull request #2602 from MikeMcQuaid/travis-ci-tweaksMike McQuaid
Travis CI tweaks
2017-05-07Travis CI tweaksMike McQuaid
Tweak our Travis CI configuration and the one we suggest for taps to be faster and use caching.
2017-05-07Merge pull request #2603 from MikeMcQuaid/tweak-gem-vendoringMike McQuaid
Tweak Gem vendoring.
2017-05-07Tweak Gem vendoring.Mike McQuaid
If people have `HOMEBREW_RUBY_PATH` set then things explode in a rather confusing fashion. Instead, run `bundle` for them with the arguments that they'd want. Also, move `macho` requires into the module itself; it's a pain having to do everything for Bundler before requiring `pathname` which is a core Ruby class.
2017-05-07Merge pull request #2597 from MikeMcQuaid/vendor-gemsMike McQuaid
Vendor all Homebrew's gems.
2017-05-07Vendor all Homebrew's gems.Mike McQuaid
Homebrew's actually ended up using a fair few gems. While we want to avoid Bundler at runtime (and this PR still does that, in fact uses Bundler even less at runtime than it did before) writing our own version to use at build-time seems redundant.
2017-05-06Merge pull request #2593 from reitermarkus/interruptMike McQuaid
Remove unused `e` from `rescue Interrupt`.
2017-05-05Remove unused `e` from `rescue Interrupt`.Markus Reiter
2017-05-05Merge pull request #2587 from decrement/patch-1Markus Reiter
Remove unused command_args
2017-05-04Add acme challenge.Mike McQuaid
2017-05-04Remove unused command_argspseudoku
Extra command_args in gain_permissions_remove caused silent failure and path never gets deleted.
2017-05-03Merge pull request #2584 from MikeMcQuaid/style-audit-onlineilovezfs
style: fix audit --online
2017-05-03style: fix audit --onlineMike McQuaid
This passed a symbol to `:except_cops` which caused a :boom:.
2017-05-03Merge pull request #2582 from MikeMcQuaid/style-fix-rubocop-requireMike McQuaid
style: don't require rubocop until installed.
2017-05-03brew.sh: >v1.2.0 now.Mike McQuaid