diff options
| -rw-r--r-- | Library/Homebrew/cmd/audit.rb | 35 |
1 files changed, 31 insertions, 4 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index 2c2b6e34b..b13a2ad9d 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -243,13 +243,40 @@ class FormulaAuditor problem "Savannah homepages should be https:// links (URL is #{homepage})." end + if homepage =~ %r[^http://((?:trac|tools|www)\.)?ietf\.org] + problem "ietf homepages should be https:// links (URL is #{homepage})." + end + + if homepage =~ %r[^http://((?:www)\.)?gnupg.org/] + problem "GnuPG homepages should be https:// links (URL is #{homepage})." + end + + # Freedesktop is complicated to handle - It has SSL/TLS, but only on certain subdomains. + # To enable https Freedesktop change the url from http://project.freedesktop.org/wiki to + # https://wiki.freedesktop.org/project_name. + # "Software" is redirected to https://wiki.freedesktop.org/www/Software/project_name + if homepage =~ %r[^http://((?:www|nice|libopenraw|liboil|telepathy|xorg)\.)?freedesktop\.org/(?:wiki/)?] + if homepage =~ /Software/ + problem "The url should be styled `https://wiki.freedesktop.org/www/Software/project_name`, not #{homepage})." + else + problem "The url should be styled `https://wiki.freedesktop.org/project_name`, not #{homepage})." + end + end + + if homepage =~ %r[^http://wiki\.freedesktop\.org/] + problem "Freedesktop's Wiki subdomain should be https:// (URL is #{homepage})." + end + # There's an auto-redirect here, but this mistake is incredibly common too. if homepage =~ %r[^http://packages\.debian\.org] problem "Debian homepage should be https:// links (URL is #{homepage})." end - if homepage =~ %r[^http://((?:trac|tools|www)\.)?ietf\.org] - problem "ietf homepages should be https:// links (URL is #{homepage})." + # People will run into mixed content sometimes, but we should enforce and then add + # exemptions as they are discovered. Treat mixed content on homepages as a bug. + # Justify each exemptions with a code comment so we can keep track here. + if homepage =~ %r[^http://[^/]*github\.io/] + problem "Github Pages links should be https:// (URL is #{homepage})." end # There's an auto-redirect here, but this mistake is incredibly common too. @@ -360,11 +387,11 @@ class FormulaAuditor end def audit_specs - if head_only?(formula) && formula.tap != "homebrew/homebrew-head-only" + if head_only?(formula) && formula.tap != "Homebrew/homebrew-head-only" problem "Head-only (no stable download)" end - if devel_only?(formula) && formula.tap != "homebrew/homebrew-devel-only" + if devel_only?(formula) && formula.tap != "Homebrew/homebrew-devel-only" problem "Devel-only (no stable download)" end |