aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorAlyssa Ross2017-12-24 14:56:07 +0000
committerAlyssa Ross2017-12-24 15:06:49 +0000
commit78fe082a2b85f097dae7b8333ba66a8fd31ca2d0 (patch)
tree2c06c76c13b621d3c8c895d556884f80438eec47 /Library
parent898981f17b21bd8caee820d8caaf6dca1e1e6c13 (diff)
downloadbrew-78fe082a2b85f097dae7b8333ba66a8fd31ca2d0.tar.bz2
cask: exit successfully when given no arguments
Fixes https://github.com/Homebrew/brew/issues/3601.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/cask/lib/hbc/cli.rb1
-rw-r--r--Library/Homebrew/test/cask/cli_spec.rb8
2 files changed, 8 insertions, 1 deletions
diff --git a/Library/Homebrew/cask/lib/hbc/cli.rb b/Library/Homebrew/cask/lib/hbc/cli.rb
index a553ad6da..5da2a137a 100644
--- a/Library/Homebrew/cask/lib/hbc/cli.rb
+++ b/Library/Homebrew/cask/lib/hbc/cli.rb
@@ -229,6 +229,7 @@ module Hbc
purpose
usage
+ return if @command.nil?
return if @command == "help" && @args.empty?
raise ArgumentError, "help does not take arguments."
diff --git a/Library/Homebrew/test/cask/cli_spec.rb b/Library/Homebrew/test/cask/cli_spec.rb
index 4a61e0088..f88af4188 100644
--- a/Library/Homebrew/test/cask/cli_spec.rb
+++ b/Library/Homebrew/test/cask/cli_spec.rb
@@ -16,10 +16,16 @@ describe Hbc::CLI, :cask do
it "ignores the `--language` option, which is handled in `OS::Mac`" do
cli = described_class.new("--language=en")
expect(cli).to receive(:detect_command_and_arguments).with(no_args)
- expect(cli).to receive(:exit).with(1)
cli.run
end
+ context "when given no arguments" do
+ it "exits successfully" do
+ expect(subject).not_to receive(:exit).with(be_nonzero)
+ subject.run
+ end
+ end
+
context "when no option is specified" do
it "--binaries is true by default" do
command = Hbc::CLI::Install.new("some-cask")