aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorMartin Kühl2010-03-12 13:24:04 +0100
committerAdam Vandenberg2010-03-16 11:54:09 -0700
commitd03411775f46165dfd1d829fa2fe4d55e2c143cc (patch)
treeb48018c3d3a3dc446860cbeb2712a38c2aa38d7d /Library
parent1e9c7df871ed48db84f597c15ce25851437c5405 (diff)
downloadbrew-d03411775f46165dfd1d829fa2fe4d55e2c143cc.tar.bz2
Fix `change_make_var!` for empty variables.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/test/test_inreplace.rb8
-rw-r--r--Library/Homebrew/utils.rb2
2 files changed, 9 insertions, 1 deletions
diff --git a/Library/Homebrew/test/test_inreplace.rb b/Library/Homebrew/test/test_inreplace.rb
index ab9659b36..74a5eed65 100644
--- a/Library/Homebrew/test/test_inreplace.rb
+++ b/Library/Homebrew/test/test_inreplace.rb
@@ -6,6 +6,14 @@ class InreplaceTest < Test::Unit::TestCase
s1.change_make_var! "FLAG", "def"
assert_equal "FLAG=def", s1
end
+
+ def test_change_make_var_empty
+ # Replace empty flag
+ s1="FLAG = \nFLAG2=abc"
+ s1.extend(HomebrewInreplaceExtension)
+ s1.change_make_var! "FLAG", "def"
+ assert_equal "FLAG=def\nFLAG2=abc", s1
+ end
def test_change_make_var_append
# Append to flag
diff --git a/Library/Homebrew/utils.rb b/Library/Homebrew/utils.rb
index 8c9aaa85d..021a93f01 100644
--- a/Library/Homebrew/utils.rb
+++ b/Library/Homebrew/utils.rb
@@ -157,7 +157,7 @@ module HomebrewInreplaceExtension
# value with "new_value", or removes the definition entirely.
def change_make_var! flag, new_value
new_value = "#{flag}=#{new_value}"
- gsub! Regexp.new("^#{flag}\\s*=\\s*(.*)$"), new_value
+ gsub! Regexp.new("^#{flag}\\s*=[ \\t]*(.*)$"), new_value
end
# Removes variable assignments completely.
def remove_make_var! flags