diff options
| author | Xu Cheng | 2016-08-05 22:01:32 +0800 |
|---|---|---|
| committer | GitHub | 2016-08-05 22:01:32 +0800 |
| commit | a8566c9848122474b92fc8989eec196d5f4fb69b (patch) | |
| tree | 896c040fb575962be0aeb27bc9a99454f3514d73 /Library/Homebrew/utils/inreplace.rb | |
| parent | 38209aadbfe4fd0c6772467c4bc5c63325d53f6c (diff) | |
| download | brew-a8566c9848122474b92fc8989eec196d5f4fb69b.tar.bz2 | |
various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)).
Diffstat (limited to 'Library/Homebrew/utils/inreplace.rb')
| -rw-r--r-- | Library/Homebrew/utils/inreplace.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Library/Homebrew/utils/inreplace.rb b/Library/Homebrew/utils/inreplace.rb index 149994223..9978b02fe 100644 --- a/Library/Homebrew/utils/inreplace.rb +++ b/Library/Homebrew/utils/inreplace.rb @@ -28,12 +28,12 @@ module Utils s.gsub!(before, after, audit_result) end - errors[path] = s.errors if s.errors.any? + errors[path] = s.errors unless s.errors.empty? Pathname(path).atomic_write(s) end - raise InreplaceError.new(errors) if errors.any? + raise InreplaceError.new(errors) unless errors.empty? end module_function :inreplace end |
