aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/dev-cmd
diff options
context:
space:
mode:
authorGautham Goli2017-07-31 14:30:37 +0530
committerGautham Goli2017-08-06 02:28:58 +0530
commit7614d2cc8be065c33f4e4e893ccd1f0995a05401 (patch)
tree8c18e57e87ac395a87eb2b4fa9c4c91f2aa7e606 /Library/Homebrew/dev-cmd
parentaffd9055c2aaaf3535ed1cb778b65a4bee5ef0e2 (diff)
downloadbrew-7614d2cc8be065c33f4e4e893ccd1f0995a05401.tar.bz2
audit: Port FileUtils, inreplace audit rules in audit_lines to rubocop
Diffstat (limited to 'Library/Homebrew/dev-cmd')
-rw-r--r--Library/Homebrew/dev-cmd/audit.rb11
1 files changed, 0 insertions, 11 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index 323b37170..cd5528cf5 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -809,17 +809,6 @@ class FormulaAuditor
end
def line_problems(line, _lineno)
- # FileUtils is included in Formula
- # encfs modifies a file with this name, so check for some leading characters
- if line =~ %r{[^'"/]FileUtils\.(\w+)}
- problem "Don't need 'FileUtils.' before #{Regexp.last_match(1)}."
- end
-
- # Check for long inreplace block vars
- if line =~ /inreplace .* do \|(.{2,})\|/
- problem "\"inreplace <filenames> do |s|\" is preferred over \"|#{Regexp.last_match(1)}|\"."
- end
-
# Check for string interpolation of single values.
if line =~ /(system|inreplace|gsub!|change_make_var!).*[ ,]"#\{([\w.]+)\}"/
problem "Don't need to interpolate \"#{Regexp.last_match(2)}\" with #{Regexp.last_match(1)}"