diff options
| author | Mike McQuaid | 2018-01-09 15:26:54 +0000 |
|---|---|---|
| committer | Mike McQuaid | 2018-01-09 15:26:54 +0000 |
| commit | 50a84f2535db0089e14a5062395ef91613155f13 (patch) | |
| tree | 7c47cb989b9d1743d75dc49aa3b0a980fefe34b4 /Library/Homebrew/dev-cmd/audit.rb | |
| parent | 9ed1ed3c0577a20b0144cb83501838b2b8c681ae (diff) | |
| download | brew-50a84f2535db0089e14a5062395ef91613155f13.tar.bz2 | |
audit: allow env :std in custom taps.
This is a nicer experience than writing `Requirement`s by hand.
Diffstat (limited to 'Library/Homebrew/dev-cmd/audit.rb')
| -rw-r--r-- | Library/Homebrew/dev-cmd/audit.rb | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 16eb03dbc..9d0ed3c59 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -304,7 +304,7 @@ class FormulaAuditor def audit_formula_name return unless @strict # skip for non-official taps - return if formula.tap.nil? || !formula.tap.official? + return unless formula.tap&.official? name = formula.name @@ -718,7 +718,13 @@ class FormulaAuditor return unless @strict - problem "`#{Regexp.last_match(1)}` in formulae is deprecated" if line =~ /(env :(std|userpaths))/ + if formula.tap&.official? && line.include?("env :std") + problem "`env :std` in official tap formulae is deprecated" + end + + if line.include?("env :userpaths") + problem "`env :userpaths` in formulae is deprecated" + end if line =~ /system ((["'])[^"' ]*(?:\s[^"' ]*)+\2)/ bad_system = Regexp.last_match(1) |
