aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGautham Goli2017-07-13 12:43:01 +0530
committerGautham Goli2017-07-13 12:43:08 +0530
commit222af824014f99be7da24f6aa8980eaf28548cb9 (patch)
tree77914e6688fdfd0295b0a21732c16372d0ba5c50
parentb8adc1a8aa59dffd063e70cb1ba78988c9745d8e (diff)
downloadbrew-222af824014f99be7da24f6aa8980eaf28548cb9.tar.bz2
Read rubocop offenses as const from corresponding class in tests
-rw-r--r--Library/Homebrew/test/rubocops/bottle_block_cop_spec.rb2
-rw-r--r--Library/Homebrew/test/rubocops/conflicts_cop_spec.rb6
2 files changed, 2 insertions, 6 deletions
diff --git a/Library/Homebrew/test/rubocops/bottle_block_cop_spec.rb b/Library/Homebrew/test/rubocops/bottle_block_cop_spec.rb
index a775b0b17..563f7ad4b 100644
--- a/Library/Homebrew/test/rubocops/bottle_block_cop_spec.rb
+++ b/Library/Homebrew/test/rubocops/bottle_block_cop_spec.rb
@@ -18,7 +18,7 @@ describe RuboCop::Cop::FormulaAuditStrict::BottleBlock do
end
EOS
- expected_offenses = [{ message: "Use rebuild instead of revision in bottle block",
+ expected_offenses = [{ message: described_class::MSG,
severity: :convention,
line: 5,
column: 4,
diff --git a/Library/Homebrew/test/rubocops/conflicts_cop_spec.rb b/Library/Homebrew/test/rubocops/conflicts_cop_spec.rb
index c3175509a..4fbab6c9e 100644
--- a/Library/Homebrew/test/rubocops/conflicts_cop_spec.rb
+++ b/Library/Homebrew/test/rubocops/conflicts_cop_spec.rb
@@ -16,11 +16,7 @@ describe RuboCop::Cop::FormulaAudit::Conflicts do
end
EOS
- msg = <<-EOS.undent
- Versioned formulae should not use `conflicts_with`.
- Use `keg_only :versioned_formula` instead.
- EOS
- expected_offenses = [{ message: msg,
+ expected_offenses = [{ message: described_class::MSG,
severity: :convention,
line: 3,
column: 2,