Merge pull request #2635 from MikeMcQuaid/no-set-blank-vars

bin/brew: don't set blank HOMEBREW_* variables.

1 files changed, 4 insertions, 0 deletions

diff --git a/bin/brew b/bin/brew
index 20cf9564d..90e0cf3e9 100755
--- a/bin/brew
+++ b/bin/brew
@@ -49,7 +49,11 @@ HOMEBREW_LIBRARY="$HOMEBREW_REPOSITORY/Library"
 for VAR in AWS_ACCESS_KEY_ID AWS_SECRET_ACCESS_KEY BINTRAY_USER BINTRAY_KEY \
            BROWSER EDITOR GIT PATH VISUAL
 do
+  # Skip if variable value is empty.
+  [[ -z "${!VAR}" ]] && continue
+
   VAR_NEW="HOMEBREW_${VAR}"
+  # Skip if existing HOMEBREW_* variable is set.
   [[ -n "${!VAR_NEW}" ]] && continue
   export "$VAR_NEW"="${!VAR}"
 done