diff options
| author | ilovezfs | 2016-12-13 11:26:23 -0800 |
|---|---|---|
| committer | GitHub | 2016-12-13 11:26:23 -0800 |
| commit | 99f42146c06333f820f45ed1940c5487990e2b31 (patch) | |
| tree | 407b336d0c90c44d59679c17b28db02680a1d60d | |
| parent | 6b4de315046a8e4d8b8b70418f7ccd15fecb7801 (diff) | |
| parent | 862c3ba4a2fb76140e46fdf49a1ea6857f140a29 (diff) | |
| download | brew-99f42146c06333f820f45ed1940c5487990e2b31.tar.bz2 | |
Merge pull request #1665 from Homebrew/revert-1592-runtime_dependencies1.1.4
Revert "formula: runtime deps of build deps aren't runtime"
| -rw-r--r-- | Library/Homebrew/formula.rb | 2 | ||||
| -rw-r--r-- | Library/Homebrew/test/formula_test.rb | 15 |
2 files changed, 5 insertions, 12 deletions
diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb index e1846424f..c80cd517f 100644 --- a/Library/Homebrew/formula.rb +++ b/Library/Homebrew/formula.rb @@ -1505,7 +1505,7 @@ class Formula # Returns a list of Dependency objects that are required at runtime. # @private def runtime_dependencies - recursive_dependencies { |_, dep| Dependency.prune if dep.build? } + recursive_dependencies.reject(&:build?) end # Returns a list of formulae depended on by this formula that aren't diff --git a/Library/Homebrew/test/formula_test.rb b/Library/Homebrew/test/formula_test.rb index 28d376b7c..a6db1b57f 100644 --- a/Library/Homebrew/test/formula_test.rb +++ b/Library/Homebrew/test/formula_test.rb @@ -651,19 +651,12 @@ class FormulaTests < Homebrew::TestCase f4 = formula("f4") do url "f4-1.0" - depends_on "f1" + depends_on "f3" end - stub_formula_loader f4 - f5 = formula("f5") do - url "f5-1.0" - depends_on "f3" => :build - depends_on "f4" - end - - assert_equal %w[f3 f4], f5.deps.map(&:name) - assert_equal %w[f1 f2 f3 f4], f5.recursive_dependencies.map(&:name) - assert_equal %w[f1 f4], f5.runtime_dependencies.map(&:name) + assert_equal %w[f3], f4.deps.map(&:name) + assert_equal %w[f1 f2 f3], f4.recursive_dependencies.map(&:name) + assert_equal %w[f2 f3], f4.runtime_dependencies.map(&:name) end def test_to_hash |
