brew/Library/Homebrew/test/test_comparableset.rb, branch 1.2.4 🍺 The missing package manager for macOS Replace ComparableSet with a Requirements collection 2014-07-03T19:50:57+00:00 Jack Nagel 2014-07-03T19:50:57+00:00 618b894c3e9cf6b0bdb2f46fd258b27d863d1373 






Use a custom test class so we can avoid monkeypatching
2014-06-19T01:32:51+00:00

Jack Nagel

2014-06-19T01:32:51+00:00

982e9239b8ba2c2a49ccedec2a108a4580047bcb












Reduce allocations in dependency construction
2013-05-06T21:08:50+00:00

Jack Nagel

2013-05-06T21:08:50+00:00

b32202033881d93849f4c44a837389e8a9d450ef

By always passing around a single, unnested array rather than splatting
and then defensively flattening and compacting things, we can avoid
allocating a bunch of unnecessary arrays. This gives a performance boost
of roughly 4% when enumerating 2500 formulae, and has the side effect of
cleaning up the dependency API.





By always passing around a single, unnested array rather than splatting
and then defensively flattening and compacting things, we can avoid
allocating a bunch of unnecessary arrays. This gives a performance boost
of roughly 4% when enumerating 2500 formulae, and has the side effect of
cleaning up the dependency API.







Fix argument order in test_comparableset
2013-04-08T23:34:55+00:00

Jack Nagel

2013-04-08T23:34:55+00:00

646102c31118144545127b7ed70512de753d1d40












Allow specifying a name attribute for X11Dependency
2013-01-28T16:35:14+00:00

Jack Nagel

2013-01-27T21:41:45+00:00

210401654bd7f22edc843164a7fea28f85b0b219












Update require
2013-01-27T22:29:19+00:00

Jack Nagel

2013-01-27T20:37:13+00:00

871f3a091accaa6828f8536da416bf4f13317d7d












ComparableSet#merge returns self
2012-10-25T20:54:55+00:00

Jack Nagel

2012-10-25T20:45:42+00:00

762c355b30798237c9f5dade43a0d8a9523bcfef

Set#merge is supposed to return self, and Formula#recursive_requirements
depended on this being true.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>





Set#merge is supposed to return self, and Formula#recursive_requirements
depended on this being true.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>







Allow requirements to record tags
2012-10-25T19:28:53+00:00

Jack Nagel

2012-10-24T23:17:43+00:00

d1f754c02e5ef36de70ac3cb7ad7669a90ec9295

To allow

  depends_on :x11 => :optional

and friends to work as expected, make requirements record any tags and
add special handling to the X11Dependency to record both a minimum
version and additional tags.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>





To allow

  depends_on :x11 => :optional

and friends to work as expected, make requirements record any tags and
add special handling to the X11Dependency to record both a minimum
version and additional tags.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>







Manage Requirements using ComparableSet
2012-10-15T14:46:29+00:00

Misty De Meo

2012-10-02T18:21:00+00:00

bbfb6400c77aeaaf88216263d86491d85a40f8a9

ComparableSet only allows a single object of a given class,
choosing the object with the greatest value. This was mainly created
for Requirements, so that, e.g., two X11Dependencies of differing
strictness don't both end up in the same requirement set.

Fixes Homebrew/homebrew#15240.




ComparableSet only allows a single object of a given class,
choosing the object with the greatest value. This was mainly created
for Requirements, so that, e.g., two X11Dependencies of differing
strictness don't both end up in the same requirement set.

Fixes Homebrew/homebrew#15240.