brew/Library/Homebrew/dependency.rb, branch 1.1.12 🍺 The missing package manager for macOS Revert "Revert "uses: properly handle untapped fo… 2017-01-16T23:28:26+00:00 Alyssa Ross 2017-01-15T17:40:51+00:00 0b216798bb33e63e7b9da795925f610f93cc1e33 …rmulae in recursive dependency expansion"" This reverts commit dc9819b86c60b5c6fd10373ff318d8ef60f97d52. 
…rmulae in recursive dependency expansion""

This reverts commit dc9819b86c60b5c6fd10373ff318d8ef60f97d52.
Revert "uses: properly handle untapped formulae in recursive dependency expansion" 2017-01-07T13:15:18+00:00 Mike McQuaid 2017-01-07T13:15:18+00:00 dc9819b86c60b5c6fd10373ff318d8ef60f97d52 






dependency: TapDependency#tap returns a Tap
2017-01-05T00:22:56+00:00

Alyssa Ross

2017-01-05T00:22:56+00:00

4c061fc1833521b3e943de2e2d16029966cd7164

Previously, this returned a String, but a Tap instance seems much more
sensible.

I couldn't find anywhere this method was actually used, so the change
shouldn't break anything.





Previously, this returned a String, but a Tap instance seems much more
sensible.

I couldn't find anywhere this method was actually used, so the change
shouldn't break anything.







Fix dependency option handling.
2016-12-10T17:58:41+00:00

Mike McQuaid

2016-12-10T17:58:41+00:00

f7f15673a8e8ecb6817435c7bd51c7e8077220e4

- formula_installer: only recompute dependencies when necessary i.e.
when a bottle pour fails.
- formula_installer: re-add accidentally remove dependency options
- dependency: missing options are only those that actually exist on a
formula





- formula_installer: only recompute dependencies when necessary i.e.
when a bottle pour fails.
- formula_installer: re-add accidentally remove dependency options
- dependency: missing options are only those that actually exist on a
formula







Style/Alias: Prefer `alias`.
2016-09-23T16:19:53+00:00

Markus Reiter

2016-09-23T16:13:48+00:00

e851c9bf6c3adda268f1a307d6b49acb1ad1852d












Dependency.expand: ensure pop stack
2016-02-07T06:58:05+00:00

Xu Cheng

2016-02-06T05:32:12+00:00

8749ecc3839c6093f56c6b80ebf794266a611472

During the dependencies expansion, there may be errors (e.g. FormulaUnavaiableError).
As result, some deps will be left behind in the stack and interfere afterwards
dependencies expansion.

So let's ensure stack clean for each expansions.

Fixes Homebrew/homebrew#48834.





During the dependencies expansion, there may be errors (e.g. FormulaUnavaiableError).
As result, some deps will be left behind in the stack and interfere afterwards
dependencies expansion.

So let's ensure stack clean for each expansions.

Fixes Homebrew/homebrew#48834.







Revert "Revert "dependency: don't recurse infinitely.""
2016-01-18T08:59:52+00:00

Mike McQuaid

2016-01-18T08:59:43+00:00

5b7dd99e999111045348637b51bd85e01d88afda

This reverts commit fa43883dd1cd82f234b79c4a322339f03b9c098d.

Closes Homebrew/homebrew#48187.





This reverts commit fa43883dd1cd82f234b79c4a322339f03b9c098d.

Closes Homebrew/homebrew#48187.







Revert "dependency: don't recurse infinitely."
2016-01-17T20:55:05+00:00

Mike McQuaid

2016-01-17T20:55:05+00:00

cd0366da0d489093a9704b0e38569ebe7bd6f4e3

This reverts commit 16ffbe1a2b2d99da42481dc50f70dbfee4472da6.





This reverts commit 16ffbe1a2b2d99da42481dc50f70dbfee4472da6.







dependency: don't recurse infinitely.
2016-01-17T20:12:03+00:00

Mike McQuaid

2016-01-17T20:11:57+00:00

20106e42684b3befd3de6c3dece9c2a6ec88871c

If we have a dependency cycle ensure that infinite recursion does not
result by storing state in a stack which we push/pop from for each
level of recursion and verify that we haven’t been through this
dependency already.

Closes Homebrew/homebrew#47933.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>





If we have a dependency cycle ensure that infinite recursion does not
result by storing state in a stack which we push/pop from for each
level of recursion and verify that we haven’t been through this
dependency already.

Closes Homebrew/homebrew#47933.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>







dependency: fix merging tags in 'merge_repeats'
2015-12-17T12:50:38+00:00

Martin Afanasjew

2015-12-15T09:50:38+00:00

ea4d137e871ace8200743f237c48189e3b930da1

While it may suffice to merge string and non-reserved tags by forming a
union of all tags of dependencies of the same name, this approach fails
to work for the reserved tags. These are now merged such that the most
restrictive tag (meaning sometimes an empty tag) is preserved.

The previous behavior caused essential dependencies to be omitted and
builds to fail in response. E.g., multiple `:fortran` dependencies with
tags `[]`, `[:recommended]`, and `[:optional]` would have been expanded
and merged to `"gcc"` with tags `[:recommended, :optional]`, causing it
to be no longer seen as a required dependency.

Closes Homebrew/homebrew#47040.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>





While it may suffice to merge string and non-reserved tags by forming a
union of all tags of dependencies of the same name, this approach fails
to work for the reserved tags. These are now merged such that the most
restrictive tag (meaning sometimes an empty tag) is preserved.

The previous behavior caused essential dependencies to be omitted and
builds to fail in response. E.g., multiple `:fortran` dependencies with
tags `[]`, `[:recommended]`, and `[:optional]` would have been expanded
and merged to `"gcc"` with tags `[:recommended, :optional]`, causing it
to be no longer seen as a required dependency.

Closes Homebrew/homebrew#47040.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>