From dc9a580617a838b63cbf5feae362b6f9cf5ed986 Mon Sep 17 00:00:00 2001 From: quazzie Date: Fri, 22 Mar 2013 10:35:50 +0100 Subject: fix($location): back-button should fire $locationChangeStart Before $locationChangeStart event is not broadcast when pressing the back-button on the browser. Closes #2109 --- test/ng/locationSpec.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'test') diff --git a/test/ng/locationSpec.js b/test/ng/locationSpec.js index bb0659a5..fb828044 100644 --- a/test/ng/locationSpec.js +++ b/test/ng/locationSpec.js @@ -1237,7 +1237,7 @@ describe('$location', function() { expect($location.url()).toEqual(''); $rootScope.$on('$locationChangeStart', function(event, newUrl, oldUrl) { - throw Error('there is no before when user enters URL directly to browser'); + $log.info('start', newUrl, oldUrl); }); $rootScope.$on('$locationChangeSuccess', function(event, newUrl, oldUrl) { $log.info('after', newUrl, oldUrl); @@ -1247,6 +1247,8 @@ describe('$location', function() { $browser.url('http://server/#/somePath'); $browser.poll(); + expect($log.info.logs.shift()). + toEqual(['start', 'http://server/#/somePath', 'http://server/']); expect($log.info.logs.shift()). toEqual(['after', 'http://server/#/somePath', 'http://server/']); }) -- cgit v1.2.3