From ce1f1f97f0ebf77941b2bdaf5e8352d33786524d Mon Sep 17 00:00:00 2001 From: Caitlin Potter Date: Mon, 27 Jan 2014 14:04:45 -0500 Subject: fix(ngResource): don't append number to '$' in url param value when encoding URI Previously, if a URL parameter value included a $, it would replace the dollar sign with a literal '$1' for mysterious reasons. Using a function rather than a replacement string circumvents this behaviour and produces a more expected result. Closes #6003 Closes #6004 --- test/ngResource/resourceSpec.js | 2 ++ 1 file changed, 2 insertions(+) (limited to 'test') diff --git a/test/ngResource/resourceSpec.js b/test/ngResource/resourceSpec.js index b23f0ca4..08c27a0f 100644 --- a/test/ngResource/resourceSpec.js +++ b/test/ngResource/resourceSpec.js @@ -178,9 +178,11 @@ describe("resource", function() { $httpBackend.expect('GET', '/Path/foo%231').respond('{}'); $httpBackend.expect('GET', '/Path/doh!@foo?bar=baz%231').respond('{}'); + $httpBackend.expect('GET', '/Path/herp$').respond('{}'); R.get({a: 'foo#1'}); R.get({a: 'doh!@foo', bar: 'baz#1'}); + R.get({a: 'herp$'}); }); -- cgit v1.2.3