From cceb455fb167571e26341ded6b595dafd4d92bc6 Mon Sep 17 00:00:00 2001 From: Sergei Z Date: Fri, 14 Feb 2014 13:54:41 +0200 Subject: fix(numberFilter): convert all non-finite/non-numbers/non-numeric strings to the empty string The previous code for filtering out non-finite numbers was broken, as it would convert `null` to `0`, as well as arrays. This change fixes this by converting null/undefined/NaN/Infinity/any object to the empty string. Closes #6188 Closes #6261 --- test/ng/filter/filtersSpec.js | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'test') diff --git a/test/ng/filter/filtersSpec.js b/test/ng/filter/filtersSpec.js index 2d648b65..66e31397 100644 --- a/test/ng/filter/filtersSpec.js +++ b/test/ng/filter/filtersSpec.js @@ -128,6 +128,11 @@ describe('filters', function() { expect(number(1234)).toEqual('1,234'); expect(number(1234.5678)).toEqual('1,234.568'); expect(number(Number.NaN)).toEqual(''); + expect(number(null)).toEqual(''); + expect(number({})).toEqual(''); + expect(number([])).toEqual(''); + expect(number(+Infinity)).toEqual(''); + expect(number(-Infinity)).toEqual(''); expect(number("1234.5678")).toEqual('1,234.568'); expect(number(1/0)).toEqual(""); expect(number(1, 2)).toEqual("1.00"); -- cgit v1.2.3