From b6e4a71166c7f00f4140fd7ea8f0cd81b4487a3f Mon Sep 17 00:00:00 2001
From: Xiangru Chen
Date: Sat, 14 Jul 2012 17:40:24 +0800
Subject: fix(ngSrc): don't set src if value is empty string

Current implementation of ngSrc may lead to empty src attribute when page is loading.

For example:

<img ng-src="{{image.url}}">
can be temporarily rendered as

<img src="">
before the image resource is loaded.

Some browser emits a request to the current page when seeing <img src=""> (Firefox13 and IE8 will, Chromium20 won't), which leads to performance problems.
---
 test/ng/directive/ngSrcSpec.js | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 test/ng/directive/ngSrcSpec.js

(limited to 'test')

diff --git a/test/ng/directive/ngSrcSpec.js b/test/ng/directive/ngSrcSpec.js
new file mode 100644
index 00000000..a917c511
--- /dev/null
+++ b/test/ng/directive/ngSrcSpec.js
@@ -0,0 +1,17 @@
+'use strict';
+
+describe('ngSrc', function() {
+  var element;
+
+  afterEach(function() {
+    dealoc(element);
+  });
+
+  it('should not result empty string in img src', inject(function($rootScope, $compile) {
+    $rootScope.image = {};
+    element = $compile('<img ng-src="{{image.url}}">')($rootScope);
+    $rootScope.$digest();
+    expect(element.attr('src')).not.toBe('');
+    expect(element.attr('src')).toBe(undefined);
+  }));
+});
-- 
cgit v1.2.3