From 5390fb37d2c01937922613fc57df4986af521787 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Fri, 23 Mar 2012 11:46:54 -0700 Subject: fix($compile): create new (isolate) scopes for directives on root elements previously we would not create them and it's causing all kinds of issues and accidental leaks Closes #817 --- test/service/compilerSpec.js | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) (limited to 'test') diff --git a/test/service/compilerSpec.js b/test/service/compilerSpec.js index a95e9eb3..d7ecdafc 100644 --- a/test/service/compilerSpec.js +++ b/test/service/compilerSpec.js @@ -1035,10 +1035,11 @@ describe('$compile', function() { ); - it('should allow more then one scope creation per element', inject( + it('should allow more one new scope directives per element, but directives should share' + + 'the scope', inject( function($rootScope, $compile, log) { - $compile('
')($rootScope); - expect(log).toEqual('001; 001'); + element = $compile('')($rootScope); + expect(log).toEqual('002; 002'); }) ); @@ -1064,10 +1065,18 @@ describe('$compile', function() { ); - it('should treat new scope on new template as noop', inject( + it('should create new scope even at the root of the template', inject( function($rootScope, $compile, log) { element = $compile('')($rootScope); - expect(log).toEqual('001'); + expect(log).toEqual('002'); + }) + ); + + + it('should create isolate scope even at the root of the template', inject( + function($rootScope, $compile, log) { + element = $compile('')($rootScope); + expect(log).toEqual('002'); }) ); }); -- cgit v1.2.3