From 49dfdf8f0238ef8c473fcb44694f6b5696ecde70 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Sun, 6 May 2012 09:27:10 -0700 Subject: fix(ngModel): use keydown/change events on IE9 instead of input On IE9 the input event is not fired when backspace or delete key are pressed or when cut is performed. This makes listening on the input event unreliable and therefore it's better for us to just use keydown/change events instead. Closes #879 --- test/ng/directive/inputSpec.js | 2 +- test/ng/snifferSpec.js | 20 ++++++++++++++------ 2 files changed, 15 insertions(+), 7 deletions(-) (limited to 'test') diff --git a/test/ng/directive/inputSpec.js b/test/ng/directive/inputSpec.js index 6cecf125..45e3e1bf 100644 --- a/test/ng/directive/inputSpec.js +++ b/test/ng/directive/inputSpec.js @@ -254,7 +254,7 @@ describe('ngModel', function() { expect(element.hasClass('ng-invalid-email')).toBe(true); element.val('invalid-again'); - browserTrigger(element, $sniffer.hasEvent('input') ? 'input' : 'change'); + browserTrigger(element, ($sniffer.hasEvent('input')) ? 'input' : 'change'); expect(element).toBeInvalid(); expect(element).toBeDirty(); expect(element.hasClass('ng-valid-email')).toBe(false); diff --git a/test/ng/snifferSpec.js b/test/ng/snifferSpec.js index 4e5f50ec..81a0db5e 100644 --- a/test/ng/snifferSpec.js +++ b/test/ng/snifferSpec.js @@ -45,10 +45,10 @@ describe('$sniffer', function() { }); - it('should return true if "oninput" is present in a div element', function() { - mockDivElement = {oninput: noop}; + it('should return true if "onchange" is present in a div element', function() { + mockDivElement = {onchange: noop}; - expect($sniffer.hasEvent('input')).toBe(true); + expect($sniffer.hasEvent('change')).toBe(true); }); @@ -62,11 +62,19 @@ describe('$sniffer', function() { it('should only create the element once', function() { mockDivElement = {}; - $sniffer.hasEvent('input'); - $sniffer.hasEvent('input'); - $sniffer.hasEvent('input'); + $sniffer.hasEvent('change'); + $sniffer.hasEvent('change'); + $sniffer.hasEvent('change'); expect(mockDocument.createElement).toHaveBeenCalledOnce(); }); + + + it('should claim that IE9 doesn\'t have support for "oninput"', function() { + // IE9 implementation is fubared, so it's better to pretend that it doesn't have the support + mockDivElement = {oninput: noop}; + + expect($sniffer.hasEvent('input')).toBe((msie == 9) ? false : true); + }); }); }); -- cgit v1.2.3