From 47f7bd706efc5f2944d182e46c1b1d324298ff36 Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Sat, 5 Oct 2013 22:45:43 +0100 Subject: fix(rootScope): make stopPropagation only stop its own event All sibling event handlers residing on the same scope to were stopped if one of them called stopPropagation. Closes #4204 --- test/ng/rootScopeSpec.js | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'test') diff --git a/test/ng/rootScopeSpec.js b/test/ng/rootScopeSpec.js index e8bf8eed..894c26d2 100644 --- a/test/ng/rootScopeSpec.js +++ b/test/ng/rootScopeSpec.js @@ -1060,6 +1060,14 @@ describe('Scope', function() { expect(log).toEqual('2>1>0>'); }); + it('should allow all events on the same scope to run even if stopPropagation is called', function(){ + child.$on('myEvent', logger); + grandChild.$on('myEvent', function(e) { e.stopPropagation(); }); + grandChild.$on('myEvent', logger); + grandChild.$on('myEvent', logger); + grandChild.$emit('myEvent'); + expect(log).toEqual('2>2>2>'); + }); it('should dispatch exceptions to the $exceptionHandler', inject(function($exceptionHandler) { -- cgit v1.2.3