From 0649009624e8e7bd6fb39537f62c6f00facbfb16 Mon Sep 17 00:00:00 2001 From: Misko Hevery Date: Wed, 22 Sep 2010 13:24:40 +0200 Subject: Refactored the Browser: - change from using prototype to inner functions to help with better compression - removed watchers (url/cookie) and introduced a poller concept - moved the checking of URL and cookie into services which register with poolers Benefits: - Smaller minified file - can call $browser.poll() from tests to simulate polling - single place where setTimeout needs to be tested - More testable $browser --- test/servicesSpec.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'test/servicesSpec.js') diff --git a/test/servicesSpec.js b/test/servicesSpec.js index b39e401c..6fa2c5f5 100644 --- a/test/servicesSpec.js +++ b/test/servicesSpec.js @@ -377,8 +377,7 @@ describe("service", function(){ expect(scope.$cookies).toEqual({}); scope.$browser.cookies('brandNew', 'cookie'); - //TODO: This is a hacky way of calling the watch function, once pooling is refactored, this will go away. - scope.$browser.watches[1](scope.$browser.cookies()); + scope.$browser.poll(); expect(scope.$cookies).toEqual({'brandNew':'cookie'}); }); @@ -448,8 +447,7 @@ describe("service", function(){ it('should deserialize json to object', function() { scope.$browser.cookies('objectCookie', '{"id":123,"name":"blah"}'); - //TODO: This is a hacky way of calling the watch function, once pooling is refactored, this will go away. - scope.$browser.watches[1](scope.$browser.cookies()); + scope.$browser.poll(); expect(scope.$sessionStore.get('objectCookie')).toEqual({id: 123, name: 'blah'}); }); -- cgit v1.2.3