From 288b69a314e9bd14458b6647532eb62aad5c5cdf Mon Sep 17 00:00:00 2001
From: Vojta Jina
Date: Thu, 14 Feb 2013 14:39:55 -0800
Subject: fix($http): do not encode special characters `@$:,` in params

encodeURIComponent is too aggressive and doesn't follow http://www.ietf.org/rfc/rfc3986.txt
with regards to the character set (pchar) allowed in path segments so we need
this test to make sure that we don't over-encode the params and break stuff
like buzz api which uses @self.

This is has already been fixed in `$resource`. This commit fixes it in a same way
for `$http` as well.

BREAKING CHANGE: $http does follow RFC3986 and does not encode special characters
like `$@,:` in params. If your application needs to encode these characters, encode
them manually, before sending the request.
---
 test/ngResource/resourceSpec.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

(limited to 'test/ngResource/resourceSpec.js')

diff --git a/test/ngResource/resourceSpec.js b/test/ngResource/resourceSpec.js
index db6fd402..3f2df284 100644
--- a/test/ngResource/resourceSpec.js
+++ b/test/ngResource/resourceSpec.js
@@ -118,9 +118,7 @@ describe("resource", function() {
   });
 
 
-  // In order to get this passed, we need to fix $http - another breaking change,
-  // so I'm gonna submit that as a separate CL.
-  xit('should not encode @ in url params', function() {
+  it('should not encode @ in url params', function() {
    //encodeURIComponent is too agressive and doesn't follow http://www.ietf.org/rfc/rfc3986.txt
    //with regards to the character set (pchar) allowed in path segments
    //so we need this test to make sure that we don't over-encode the params and break stuff like
-- 
cgit v1.2.3