From f2106692b1ebf00aa5f8b2accd75f014b6cd4faa Mon Sep 17 00:00:00 2001
From: Vojta Jina
Date: Wed, 28 Mar 2012 13:47:57 -0700
Subject: fix($compile): properly clone attr.$observers in ng-repeat

The `attr` object was only shallow copied which caused all observers to be shared.
Fixing similar issue in ng-* boolean attributes as well as ng-src and ng-href.
---
 test/ng/compilerSpec.js | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

(limited to 'test/ng')

diff --git a/test/ng/compilerSpec.js b/test/ng/compilerSpec.js
index dc2e20cf..fb5e99e6 100644
--- a/test/ng/compilerSpec.js
+++ b/test/ng/compilerSpec.js
@@ -1374,6 +1374,41 @@ describe('$compile', function() {
     });
 
 
+    it('should properly $observe inside ng-repeat', function() {
+      var spies = [];
+
+      module(function($compileProvider) {
+        $compileProvider.directive('observer', function() {
+          return function(scope, elm, attr) {
+            spies.push(jasmine.createSpy('observer ' + spies.length));
+            attr.$observe('some', spies[spies.length - 1]);
+          };
+        });
+      });
+
+      inject(function($compile, $rootScope) {
+        element = $compile('<div><div ng-repeat="i in items">'+
+                              '<span some="id_{{i.id}}" observer></span>'+
+                           '</div></div>')($rootScope);
+
+        $rootScope.$apply(function() {
+          $rootScope.items = [{id: 1}, {id: 2}];
+        });
+
+        expect(spies[0]).toHaveBeenCalledOnceWith('id_1');
+        expect(spies[1]).toHaveBeenCalledOnceWith('id_2');
+        spies[0].reset();
+        spies[1].reset();
+
+        $rootScope.$apply(function() {
+          $rootScope.items[0].id = 5;
+        });
+
+        expect(spies[0]).toHaveBeenCalledOnceWith('id_5');
+      });
+    });
+
+
     describe('$set', function() {
       var attr;
       beforeEach(function(){
-- 
cgit v1.2.3

orm class='right' method='get' action='/fork/homebrew/log/Library/Formula/findutils.rb'>
<input type='hidden' name='id' value='ad54c3ecf895bb7e7c9c4d77d0fffe9075a4a1db'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/fork/homebrew/log/?id=ad54c3ecf895bb7e7c9c4d77d0fffe9075a4a1db'>root</a>/<a href='/fork/homebrew/log/Library?id=ad54c3ecf895bb7e7c9c4d77d0fffe9075a4a1db'>Library</a>/<a href='/fork/homebrew/log/Library/Formula?id=ad54c3ecf895bb7e7c9c4d77d0fffe9075a4a1db'>Formula</a>/<a href='/fork/homebrew/log/Library/Formula/findutils.rb?id=ad54c3ecf895bb7e7c9c4d77d0fffe9075a4a1db'>findutils.rb</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/fork/homebrew/log/Library/Formula/findutils.rb?id=ad54c3ecf895bb7e7c9c4d77d0fffe9075a4a1db&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2014-02-22 22:44:30 +0000'>2014-02-22</span></td><td><a href='/fork/homebrew/commit/Library/Formula/findutils.rb?id=6f6044d3ce1e878a6a74e8a1c0673e69a7b47631'>findutils: add bottle.</a></td><td>Mike McQuaid</td></tr>
<tr><td><span title='2012-12-04 11:43:10 +0000'>2012-12-04</span></td><td><a href='/fork/homebrew/commit/Library/Formula/findutils.rb?id=9dc265a2f4cd46400674e7154f4700df5a2bd064'>findutils: put locate database in #{var}/locate.</a></td><td>Mike McQuaid</td></tr>
<tr><td><span title='2012-10-24 08:54:14 -0700'>2012-10-24</span></td><td><a href='/fork/homebrew/commit/Library/Formula/findutils.rb?id=641070518a0660f3c87e8deab1e70f580d5120b7'>findutils: add --default-names option</a></td><td>Daniel Schuler</td></tr>
<tr><td><span title='2012-09-03 11:36:42 -0700'>2012-09-03</span></td><td><a href='/fork/homebrew/commit/Library/Formula/findutils.rb?id=3c5ca25cad4a19b72006dffe1c782a58f4e8154b'>Batch convert MD5 formula to SHA1.</a></td><td>Mike McQuaid</td></tr>