From e415e916e85040fe62c801092be698ab06c1d11c Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Tue, 31 Dec 2013 01:36:01 -0800 Subject: test(compileSpec): fix broken build on FF FF 26.0 now throws: "TypeError: NodeList doesn't have an indexed property setter." when we try to assign to `childNodes[1]`, since this test still works properly on Chrome and the issue being tested is not a cross-browser issues, I'm just making the patchability check more robust instead of trying to figure out how to make this test fully pass on FF. --- test/ng/compileSpec.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'test/ng') diff --git a/test/ng/compileSpec.js b/test/ng/compileSpec.js index 39e23695..c37461fc 100755 --- a/test/ng/compileSpec.js +++ b/test/ng/compileSpec.js @@ -202,9 +202,14 @@ describe('$compile', function() { if (msie < 9) return; element = jqLite('
{{1+2}}
'); - element[0].childNodes[1] = {nodeType: 3, nodeName: 'OBJECT', textContent: 'fake node'}; - if (!element[0].childNodes[1]) return; //browser doesn't support this kind of mocking + try { + element[0].childNodes[1] = {nodeType: 3, nodeName: 'OBJECT', textContent: 'fake node'}; + } catch(e) { + } finally { + if (!element[0].childNodes[1]) return; //browser doesn't support this kind of mocking + } + expect(element[0].childNodes[1].textContent).toBe('fake node'); $compile(element)($rootScope); @@ -4243,7 +4248,7 @@ describe('$compile', function() { expect(element.attr('test2')).toBe('Misko'); expect(element.attr('test3')).toBe('Misko'); })); - + it('should work with the "href" attribute', inject(function($compile, $rootScope) { $rootScope.value = 'test'; element = $compile('')($rootScope); -- cgit v1.2.3