From 1d7a95df565192fc02a18b0b297b39dd615eaeb5 Mon Sep 17 00:00:00 2001 From: Daniel Luz Date: Sun, 4 Nov 2012 19:11:24 -0200 Subject: feat(scope): only evaluate constant $watch expressions once --- test/ng/rootScopeSpec.js | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) (limited to 'test/ng') diff --git a/test/ng/rootScopeSpec.js b/test/ng/rootScopeSpec.js index 49364888..33db814c 100644 --- a/test/ng/rootScopeSpec.js +++ b/test/ng/rootScopeSpec.js @@ -99,6 +99,14 @@ describe('Scope', function() { expect(spy).wasCalled(); })); + it('should not keep constant expressions on watch queue', inject(function($rootScope) { + $rootScope.$watch('1 + 1', function() {}); + expect($rootScope.$$watchers.length).toEqual(1); + $rootScope.$digest(); + + expect($rootScope.$$watchers.length).toEqual(0); + })); + it('should delegate exceptions', function() { module(function($exceptionHandlerProvider) { @@ -119,10 +127,14 @@ describe('Scope', function() { var log = ''; $rootScope.$watch('a', function() { log += 'a'; }); $rootScope.$watch('b', function() { log += 'b'; }); + // constant expressions have slightly different handling, + // let's ensure they are kept in the same list as others + $rootScope.$watch('1', function() { log += '1'; }); $rootScope.$watch('c', function() { log += 'c'; }); + $rootScope.$watch('2', function() { log += '2'; }); $rootScope.a = $rootScope.b = $rootScope.c = 1; $rootScope.$digest(); - expect(log).toEqual('abc'); + expect(log).toEqual('ab1c2'); })); -- cgit v1.2.3