From 15c1fe392942b70e456f10afbdfd9c3329249a43 Mon Sep 17 00:00:00 2001 From: Vojta Jina Date: Fri, 30 Mar 2012 15:03:20 -0700 Subject: refactor(ngView): remove extra $watch, refactor one ugly test --- test/ng/directive/ngViewSpec.js | 40 ++++++++++++++++++---------------------- 1 file changed, 18 insertions(+), 22 deletions(-) (limited to 'test/ng') diff --git a/test/ng/directive/ngViewSpec.js b/test/ng/directive/ngViewSpec.js index 636e15a8..4c0b841b 100644 --- a/test/ng/directive/ngViewSpec.js +++ b/test/ng/directive/ngViewSpec.js @@ -137,33 +137,29 @@ describe('ng-view', function() { }); - it('should be possible to nest ng-view in ng-include', inject(function() { - // TODO(vojta): refactor this test - dealoc(element); - var injector = angular.injector(['ng', 'ngMock', function($routeProvider) { - $routeProvider.when('/foo', {controller: angular.noop, template: 'viewPartial.html'}); - }]); - var myApp = injector.get('$rootScope'); - var $httpBackend = injector.get('$httpBackend'); - $httpBackend.expect('GET', 'includePartial.html').respond('view: '); - injector.get('$location').path('/foo'); + it('should be possible to nest ng-view in ng-include', function() { + + module(function($routeProvider) { + $routeProvider.when('/foo', {template: 'viewPartial.html'}); + }); - var $route = injector.get('$route'); + inject(function($httpBackend, $location, $route, $compile, $rootScope) { + $httpBackend.whenGET('includePartial.html').respond('view: '); + $httpBackend.whenGET('viewPartial.html').respond('content'); + $location.path('/foo'); - element = injector.get('$compile')( + var elm = $compile( '
' + 'include: ' + - '
')(myApp); - myApp.$apply(); - - $httpBackend.expect('GET', 'viewPartial.html').respond('content'); - $httpBackend.flush(); + '')($rootScope); + $rootScope.$digest(); + $httpBackend.flush(); - expect(element.text()).toEqual('include: view: content'); - expect($route.current.template).toEqual('viewPartial.html'); - dealoc(myApp); - dealoc(element); - })); + expect(elm.text()).toEqual('include: view: content'); + expect($route.current.template).toEqual('viewPartial.html'); + dealoc(elm) + }); + }); it('should initialize view template after the view controller was initialized even when ' + -- cgit v1.2.3