From e9a222418a029d830698444cf95bf13f8ad75805 Mon Sep 17 00:00:00 2001 From: Ricardo Bin Date: Tue, 3 Sep 2013 18:19:38 -0300 Subject: fix($httpBackend): set headers with falsy values This is a breaking change. To migrate to the new behavior, delete or set headers to `undefined` to avoid having them sent. To restore the old behavior, override `$httpBackendProvider` with the old implementation. Closes #2984 --- test/ng/httpBackendSpec.js | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) (limited to 'test/ng/httpBackendSpec.js') diff --git a/test/ng/httpBackendSpec.js b/test/ng/httpBackendSpec.js index 5d2654a9..faec5737 100644 --- a/test/ng/httpBackendSpec.js +++ b/test/ng/httpBackendSpec.js @@ -101,6 +101,22 @@ describe('$httpBackend', function() { }); }); + it('should set requested headers even if they have falsy values', function() { + $backend('POST', 'URL', null, noop, { + 'X-header1': 0, + 'X-header2': '', + 'X-header3': false, + 'X-header4': undefined + }); + + xhr = MockXhr.$$lastInstance; + + expect(xhr.$$reqHeaders).toEqual({ + 'X-header1': 0, + 'X-header2': '', + 'X-header3': false + }); + }); it('should abort request on timeout', function() { callback.andCallFake(function(status, response) { @@ -388,6 +404,7 @@ describe('$httpBackend', function() { expect(callback).toHaveBeenCalled(); expect(callback.mostRecentCall.args[0]).toBe(404); }); + }); }); -- cgit v1.2.3