From 427ee93f11d0ef64b8844f9b43b2a0f21f2be2cb Mon Sep 17 00:00:00 2001 From: Chirayu Krishnappa Date: Mon, 26 Aug 2013 17:26:08 -0700 Subject: fix(core): parse IE11 UA string correctly It's great that IE11 wants to be compatible enough that it doesn't want to be special cased and treated differently. However, as long as one has to have a different code path for IE than for the other supported browsers, we still need to detect and special case it. For instance, our URL parsing code still needs the same workaround the we used for IE10. We still see the same Access denied / TypeError exceptions when setting certain values. FYI, Angular doesn't generally blindly test for IE – we also check the version number. Thanks to modern.ie for the free IE11 test VM. Closes #3682 --- test/ng/compileSpec.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'test/ng/compileSpec.js') diff --git a/test/ng/compileSpec.js b/test/ng/compileSpec.js index 13604f6f..d2643878 100755 --- a/test/ng/compileSpec.js +++ b/test/ng/compileSpec.js @@ -2897,7 +2897,7 @@ describe('$compile', function() { })); - // Fails on IE < 10 with "TypeError: Access is denied" when trying to set img[src] + // Fails on IE <= 10 with "TypeError: Access is denied" when trying to set img[src] if (!msie || msie > 10) { it('should sanitize mailto: urls', inject(function($compile, $rootScope) { element = $compile('')($rootScope); @@ -3008,9 +3008,9 @@ describe('$compile', function() { inject(function($compile, $rootScope) { element = $compile('')($rootScope); - // Fails on IE < 10 with "TypeError: Object doesn't support this property or method" when + // Fails on IE <= 11 with "TypeError: Object doesn't support this property or method" when // trying to set img[src] - if (!msie || msie > 10) { + if (!msie || msie > 11) { $rootScope.testUrl = "javascript:doEvilStuff()"; $rootScope.$apply(); expect(element.attr('src')).toBe('javascript:doEvilStuff()'); -- cgit v1.2.3