From 4c8eaa1eb05ba98d30ff83f4420d6fcd69045d99 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Sun, 14 Aug 2011 03:24:09 -0700 Subject: refactor(jqLite): remove jqLite show/hide support it turns out that even with our tricks, jqLite#show is not usable in practice and definitely not on par with jQuery. so rather than introducing half-baked apis which introduce issues, I'm removing them. I also removed show/hide uses from docs, since they are not needed. Breaks jqLite.hide/jqLite.show which are no longer available. --- test/jqLiteSpec.js | 56 ------------------------------------------------------ 1 file changed, 56 deletions(-) (limited to 'test/jqLiteSpec.js') diff --git a/test/jqLiteSpec.js b/test/jqLiteSpec.js index 11b9db93..309fb243 100644 --- a/test/jqLiteSpec.js +++ b/test/jqLiteSpec.js @@ -511,62 +511,6 @@ describe('jqLite', function(){ }); - describe('hide', function() { - var element; - - afterEach(function() { - if (element) dealoc(element); - }); - - it('should hide the element', function() { - element = jqLite('
'); - expect(isCssVisible(element)).toBe(true); - element.hide(); - expect(isCssVisible(element)).toBe(false); - }); - }); - - - describe('show', function() { - var element; - - afterEach(function() { - if (element) dealoc(element); - element.remove(); - }); - - - it('should show the element ', function() { - element = jqLite('
'); - element[0].style.display = 'none'; - expect(isCssVisible(element)).toBe(false); - element.show(); - expect(isCssVisible(element)).toBe(true); - }); - - - it('should show previously hidden element and preserve the display value', function() { - element = jqLite('
xx
'); - jqLite(document.body).append(element); - element.hide(); - expect(isCssVisible(element)).toBe(false); - element.show(); - expect(element[0].style.display).toBe('inline'); - expect(isCssVisible(element)).toBe(true); - - element[0].style.display = 'block'; - element.hide(); - expect(isCssVisible(element)).toBe(false); - element.show(); - expect(isCssVisible(element)).toBe(true); - - // this totally doesn't make sense, it should be 'block', but jquery (1.4.2+1.6.2) behaves - // this way. - expect(element[0].style.display).toBe('inline'); - }); - }); - - describe('eq', function() { it('should select the nth element ', function() { var element = jqLite('
aa
bb
'); -- cgit v1.2.3