From 86d191ed4aea9015adc71b852223475c5c762c34 Mon Sep 17 00:00:00 2001 From: Andrew McLeod Date: Mon, 25 Feb 2013 21:25:18 -0800 Subject: fix($http): don't encode URL query substring "null" to "+" Fixes issue in encodeUriQuery used by $http and $resource that treats null as a string and replaces the characters "null" with "+". --- test/AngularSpec.js | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) (limited to 'test/AngularSpec.js') diff --git a/test/AngularSpec.js b/test/AngularSpec.js index aed191e7..cc752b6c 100644 --- a/test/AngularSpec.js +++ b/test/AngularSpec.js @@ -415,6 +415,14 @@ describe('angular', function() { //encode ' ' as '%20' when a flag is used expect(encodeUriQuery(' ', true)). toEqual('%20%20'); + + //do not encode `null` as '+' when flag is used + expect(encodeUriQuery('null', true)). + toEqual('null'); + + //do not encode `null` with no flag + expect(encodeUriQuery('null')). + toEqual('null'); }); }); @@ -673,7 +681,7 @@ describe('angular', function() { toBe(''); }); }); - + describe('startingTag', function() { it('should allow passing in Nodes instead of Elements', function() { var txtNode = document.createTextNode('some text'); @@ -741,11 +749,11 @@ describe('angular', function() { describe('noConflict', function() { var globalAngular; beforeEach(function() { - globalAngular = angular; + globalAngular = angular; }); afterEach(function() { - angular = globalAngular; + angular = globalAngular; }); it('should return angular', function() { @@ -757,7 +765,7 @@ describe('angular', function() { var a = angular.noConflict(); expect(angular).toBeUndefined(); }); - + }); }); -- cgit v1.2.3