From cceb455fb167571e26341ded6b595dafd4d92bc6 Mon Sep 17 00:00:00 2001 From: Sergei Z Date: Fri, 14 Feb 2014 13:54:41 +0200 Subject: fix(numberFilter): convert all non-finite/non-numbers/non-numeric strings to the empty string The previous code for filtering out non-finite numbers was broken, as it would convert `null` to `0`, as well as arrays. This change fixes this by converting null/undefined/NaN/Infinity/any object to the empty string. Closes #6188 Closes #6261 --- src/ng/filter/filters.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/ng/filter/filters.js b/src/ng/filter/filters.js index 15cc6e33..b8cc655c 100644 --- a/src/ng/filter/filters.js +++ b/src/ng/filter/filters.js @@ -118,7 +118,7 @@ function numberFilter($locale) { var DECIMAL_SEP = '.'; function formatNumber(number, pattern, groupSep, decimalSep, fractionSize) { - if (isNaN(number) || !isFinite(number)) return ''; + if (number == null || !isFinite(number) || isObject(number)) return ''; var isNegative = number < 0; number = Math.abs(number); -- cgit v1.2.3