From caeb1bf899bfcc10b5860ad1b6632a3fe7b0b85f Mon Sep 17 00:00:00 2001 From: Vojta Jina Date: Thu, 3 Nov 2011 17:14:03 -0700 Subject: feat($httpBackend): fix 0 status code when "file" protocol Browsers return always 0 status code for "file" protocol, so we convert them into 200/404. --- src/service/httpBackend.js | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) (limited to 'src') diff --git a/src/service/httpBackend.js b/src/service/httpBackend.js index 28700940..7443347f 100644 --- a/src/service/httpBackend.js +++ b/src/service/httpBackend.js @@ -17,19 +17,14 @@ var XHR = window.XMLHttpRequest || function() { */ function $HttpBackendProvider() { this.$get = ['$browser', '$window', '$document', function($browser, $window, $document) { - return createHttpBackend($browser, XHR, $browser.defer, $window, $document[0].body); + return createHttpBackend($browser, XHR, $browser.defer, $window, $document[0].body, + $window.location.href.replace(':', '')); }]; } -function createHttpBackend($browser, XHR, $browserDefer, $window, body) { +function createHttpBackend($browser, XHR, $browserDefer, $window, body, locationProtocol) { var idCounter = 0; - function completeRequest(callback, status, response) { - // normalize IE bug (http://bugs.jquery.com/ticket/1450) - callback(status == 1223 ? 204 : status, response); - $browser.$$completeOutstandingRequest(noop); - } - // TODO(vojta): fix the signature return function(method, url, post, callback, headers, timeout) { $browser.$$incOutstandingRequestCount(); @@ -81,6 +76,20 @@ function createHttpBackend($browser, XHR, $browserDefer, $window, body) { return xhr; } + + function completeRequest(callback, status, response) { + // URL_MATCH is defined in src/service/location.js + var protocol = (url.match(URL_MATCH) || ['', locationProtocol])[1]; + + // fix status code for file protocol (it's always 0) + status = protocol == 'file' ? (response ? 200 : 404) : status; + + // normalize IE bug (http://bugs.jquery.com/ticket/1450) + status = status == 1223 ? 204 : status; + + callback(status, response); + $browser.$$completeOutstandingRequest(noop); + } }; } -- cgit v1.2.3