From bb5abe0e9ca37288cd2b2b16aba46f702d1243c0 Mon Sep 17 00:00:00 2001 From: Javier Mendiara CaƱardo Date: Mon, 18 Mar 2013 19:18:30 +0100 Subject: chore(Angular): remove superfluous fromCharCode function Remove fromCharCode function as it was used only in two inner functions in the code, and its functionality is achieved in several other places by using String.fromCharCode Breaks fromCharCode closure function, String.fromCharCode should be used instead --- src/Angular.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/Angular.js b/src/Angular.js index 20c032c1..5177cf78 100644 --- a/src/Angular.js +++ b/src/Angular.js @@ -28,12 +28,12 @@ var uppercase = function(string){return isString(string) ? string.toUpperCase() var manualLowercase = function(s) { return isString(s) - ? s.replace(/[A-Z]/g, function(ch) {return fromCharCode(ch.charCodeAt(0) | 32);}) + ? s.replace(/[A-Z]/g, function(ch) {return String.fromCharCode(ch.charCodeAt(0) | 32);}) : s; }; var manualUppercase = function(s) { return isString(s) - ? s.replace(/[a-z]/g, function(ch) {return fromCharCode(ch.charCodeAt(0) & ~32);}) + ? s.replace(/[a-z]/g, function(ch) {return String.fromCharCode(ch.charCodeAt(0) & ~32);}) : s; }; @@ -46,8 +46,6 @@ if ('i' !== 'I'.toLowerCase()) { uppercase = manualUppercase; } -function fromCharCode(code) {return String.fromCharCode(code);} - var /** holds major version number for IE or NaN for real browsers */ msie = int((/msie (\d+)/.exec(lowercase(navigator.userAgent)) || [])[1]), -- cgit v1.2.3