From 8a8a2cf4623708b69dba3816e22b01407e338b73 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Tue, 12 Jul 2011 00:47:07 -0700 Subject: refactor($browser.xhr): use $browser.addJs for JSONP There is no reason why we shouldn't reuse $browser.addJs for JSONP requests. --- src/Browser.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/Browser.js b/src/Browser.js index 535396bd..4340ac4e 100644 --- a/src/Browser.js +++ b/src/Browser.js @@ -89,14 +89,12 @@ function Browser(window, document, body, XHR, $log) { outstandingRequestCount ++; if (lowercase(method) == 'json') { var callbackId = ("angular_" + Math.random() + '_' + (idCounter++)).replace(/\d\./, ''); - var script = jqLite(rawDocument.createElement('script')) - .attr({type: 'text/javascript', src: url.replace('JSON_CALLBACK', callbackId)}); + var script = self.addJs(url.replace('JSON_CALLBACK', callbackId)); window[callbackId] = function(data){ delete window[callbackId]; - script.remove(); + body[0].removeChild(script) completeOutstandingRequest(callback, 200, data); }; - body.append(script); } else { var xhr = new XHR(); xhr.open(method, url, true); -- cgit v1.2.3