From 7b7be341b6081792130223e220ca80002c32b290 Mon Sep 17 00:00:00 2001 From: Sebastian Müller Date: Sat, 20 Apr 2013 19:35:11 +0200 Subject: refactor(core): use native String.prototype.trim if available --- src/Angular.js | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/Angular.js b/src/Angular.js index 362bc09b..467af4ce 100644 --- a/src/Angular.js +++ b/src/Angular.js @@ -442,9 +442,20 @@ function isBoolean(value) { } -function trim(value) { - return isString(value) ? value.replace(/^\s*/, '').replace(/\s*$/, '') : value; -} +var trim = (function() { + // native trim is way faster: http://jsperf.com/angular-trim-test + // but IE doesn't have it... :-( + // TODO: we should move this into IE/ES5 polyfill + if (!String.prototype.trim) { + return function(value) { + return isString(value) ? value.replace(/^\s*/, '').replace(/\s*$/, '') : value; + }; + } + return function(value) { + return isString(value) ? value.trim() : value; + }; +})(); + /** * @ngdoc function -- cgit v1.2.3