From 6ecac8e71a84792a434d21db2c245b3648c55f18 Mon Sep 17 00:00:00 2001
From: Misko Hevery
Date: Thu, 15 Mar 2012 14:19:20 -0700
Subject: fix(select): multiselect failes to update view on selection insert

In multiselect when the underlying selection array push/pops an element the view did not re-render since the array reference stayed the same.
---
 src/directive/select.js | 10 ++++++++++
 1 file changed, 10 insertions(+)

(limited to 'src')

diff --git a/src/directive/select.js b/src/directive/select.js
index 9ea0186d..b70339fc 100644
--- a/src/directive/select.js
+++ b/src/directive/select.js
@@ -174,6 +174,7 @@ var selectDirective = ['$compile', '$parse', function($compile,   $parse) {
       }
 
       function Multiple(scope, selectElement, ctrl) {
+        var lastView;
         ctrl.$render = function() {
           var items = new HashMap(ctrl.$viewValue);
           forEach(selectElement.children(), function(option) {
@@ -181,6 +182,15 @@ var selectDirective = ['$compile', '$parse', function($compile,   $parse) {
           });
         };
 
+        // we have to do it on each watch since ng-model watches reference, but
+        // we need to work of an array, so we need to see if anything was inserted/removed
+        scope.$watch(function() {
+          if (!equals(lastView, ctrl.$viewValue)) {
+            lastView = copy(ctrl.$viewValue);
+            ctrl.$render();
+          }
+        });
+
         selectElement.bind('change', function() {
           scope.$apply(function() {
             var array = [];
-- 
cgit v1.2.3