From 65585a2d3c4f73a17d20310de30546116a9a6827 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Sun, 27 Feb 2011 15:54:06 -0800 Subject: $cookie factory fn should not run $eval --- src/service/cookies.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/service/cookies.js b/src/service/cookies.js index 082b73ab..b8de81c2 100644 --- a/src/service/cookies.js +++ b/src/service/cookies.js @@ -16,7 +16,8 @@ angularServiceInject('$cookies', function($browser) { var rootScope = this, cookies = {}, lastCookies = {}, - lastBrowserCookies; + lastBrowserCookies, + runEval = false; //creates a poller fn that copies all cookies from the $browser to service & inits the service $browser.addPollFn(function() { @@ -25,10 +26,12 @@ angularServiceInject('$cookies', function($browser) { lastBrowserCookies = currentCookies; copy(currentCookies, lastCookies); copy(currentCookies, cookies); - rootScope.$eval(); + if (runEval) rootScope.$eval(); } })(); + runEval = true; + //at the end of each eval, push cookies //TODO: this should happen before the "delayed" watches fire, because if some cookies are not // strings or browser refuses to store some cookies, we update the model in the push fn. -- cgit v1.2.3