From 509ec745fdbb54b54672fbf8595a4958c16f2b53 Mon Sep 17 00:00:00 2001
From: Igor Minar
Date: Sat, 23 Feb 2013 22:16:35 -0800
Subject: fix($httpBackend): prevent DOM err due to dereferencing .responseText

If responseType is defined and the request fails for one reason or another
the .response property returned falsy value which caused dereferencing of
.responseText. If the responseType was a blob or document then an error
was thrown.

To prevent this, I'm checking for responseType first and based on that
dereferencing .response or .responseText.

We need to keep on checking .responseText because that's the original XHR
response api that is still needed for IE8 and 9.

Closes #1922
---
 src/ng/httpBackend.js | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

(limited to 'src')

diff --git a/src/ng/httpBackend.js b/src/ng/httpBackend.js
index 5c967c6b..91ebe03d 100644
--- a/src/ng/httpBackend.js
+++ b/src/ng/httpBackend.js
@@ -87,8 +87,12 @@ function createHttpBackend($browser, XHR, $browserDefer, callbacks, rawDocument,
           }
           // end of the workaround.
 
-          completeRequest(callback, status || xhr.status, xhr.response || xhr.responseText,
-                          responseHeaders);
+          // responseText is the old-school way of retrieving response (supported by IE8 & 9)
+          // response and responseType properties were introduced in XHR Level2 spec (supported by IE10)
+          completeRequest(callback,
+              status || xhr.status,
+              (xhr.responseType ? xhr.response : xhr.responseText),
+              responseHeaders);
         }
       };
 
-- 
cgit v1.2.3