From 4612705ec297bc6ba714cb7a98f1be6aff77c4b8 Mon Sep 17 00:00:00 2001 From: Tobias Bosch Date: Mon, 11 Nov 2013 15:54:24 -0800 Subject: fix(ngIf): don't create multiple elements when changing from a truthy to another thruthy value. Fixes #4852. --- src/ng/directive/ngIf.js | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) (limited to 'src') diff --git a/src/ng/directive/ngIf.js b/src/ng/directive/ngIf.js index 5ff889c2..6e845e28 100644 --- a/src/ng/directive/ngIf.js +++ b/src/ng/directive/ngIf.js @@ -60,7 +60,7 @@ } /* - The transition styles can also be placed on the CSS base class above + The transition styles can also be placed on the CSS base class above */ .animate-if.ng-enter, .animate-if.ng-leave { -webkit-transition:all cubic-bezier(0.250, 0.460, 0.450, 0.940) 0.5s; @@ -92,16 +92,16 @@ var ngIfDirective = ['$animate', function($animate) { $scope.$watch($attr.ngIf, function ngIfWatchAction(value) { if (toBoolean(value)) { - - childScope = $scope.$new(); - transclude(childScope, function (clone) { - block = { - startNode: clone[0], - endNode: clone[clone.length++] = document.createComment(' end ngIf: ' + $attr.ngIf + ' ') - }; - $animate.enter(clone, $element.parent(), $element); - }); - + if (!childScope) { + childScope = $scope.$new(); + transclude(childScope, function (clone) { + block = { + startNode: clone[0], + endNode: clone[clone.length++] = document.createComment(' end ngIf: ' + $attr.ngIf + ' ') + }; + $animate.enter(clone, $element.parent(), $element); + }); + } } else { if (childScope) { -- cgit v1.2.3