From 44b6b72e5e9d193ec878ac7a4f25a00815f68cca Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Fri, 16 Aug 2013 06:21:26 -0700 Subject: fix($injector): don't parse fns with no args When annotating a fn, it is wasteful to try to parse a fn that has no arguments as such fn has no injectable dependencies --- src/auto/injector.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'src') diff --git a/src/auto/injector.js b/src/auto/injector.js index f165030f..96ea0bf4 100644 --- a/src/auto/injector.js +++ b/src/auto/injector.js @@ -52,13 +52,15 @@ function annotate(fn) { if (typeof fn == 'function') { if (!($inject = fn.$inject)) { $inject = []; - fnText = fn.toString().replace(STRIP_COMMENTS, ''); - argDecl = fnText.match(FN_ARGS); - forEach(argDecl[1].split(FN_ARG_SPLIT), function(arg){ - arg.replace(FN_ARG, function(all, underscore, name){ - $inject.push(name); + if (fn.length) { + fnText = fn.toString().replace(STRIP_COMMENTS, ''); + argDecl = fnText.match(FN_ARGS); + forEach(argDecl[1].split(FN_ARG_SPLIT), function(arg){ + arg.replace(FN_ARG, function(all, underscore, name){ + $inject.push(name); + }); }); - }); + } fn.$inject = $inject; } } else if (isArray(fn)) { -- cgit v1.2.3