From 2315d9b3610994b36c44e4a97fb1427d59471ce8 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Wed, 14 Mar 2012 13:03:53 -0700 Subject: fix(ng-switch): properly destroy child scopes --- src/directive/ngSwitch.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/directive/ngSwitch.js b/src/directive/ngSwitch.js index 59c7056e..16b0c4d4 100644 --- a/src/directive/ngSwitch.js +++ b/src/directive/ngSwitch.js @@ -69,19 +69,21 @@ var ngSwitchDirective = valueFn({ element.data(NG_SWITCH, cases); return function(scope, element){ var selectedTransclude, - selectedElement; + selectedElement, + selectedScope; scope.$watch(watchExpr, function(value) { if (selectedElement) { + selectedScope.$destroy(); selectedElement.remove(); - selectedElement = null; + selectedElement = selectedScope = null; } if ((selectedTransclude = cases['!' + value] || cases['?'])) { scope.$eval(attr.change); - selectedTransclude(scope.$new(), function(caseElement, scope) { + selectedScope = scope.$new(); + selectedTransclude(selectedScope, function(caseElement) { selectedElement = caseElement; element.append(caseElement); - element.bind('$destroy', bind(scope, scope.$destroy)); }); } }); -- cgit v1.2.3