From 142cffcf64d2dce93089e9a73257bddf50e96990 Mon Sep 17 00:00:00 2001 From: Di Peng Date: Fri, 5 Aug 2011 15:01:58 -0700 Subject: refactor(widgets): remove input[button, submit, reset, image] and button windgets These widgets are useless and only trigger extra $updateViews. The only reason we had them was to support ng:change on these widgets, but since there are no bindings present in these cases it doesn't make sense to support ng:change here. It's likely just a leftover from getangular.com Breaking change: ng:change for input[button], input[submit], input[reset], input[image] and button widgets is not supported any more --- src/widgets.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'src') diff --git a/src/widgets.js b/src/widgets.js index a2a4109b..438fccb3 100644 --- a/src/widgets.js +++ b/src/widgets.js @@ -445,16 +445,11 @@ function noopAccessor() { return { get: noop, set: noop }; } * */ var textWidget = inputWidget('keydown change', modelAccessor, valueAccessor, initWidgetValue(), true), - buttonWidget = inputWidget('click', noopAccessor, noopAccessor, noop), INPUT_TYPE = { 'text': textWidget, 'textarea': textWidget, 'hidden': textWidget, 'password': textWidget, - 'button': buttonWidget, - 'submit': buttonWidget, - 'reset': buttonWidget, - 'image': buttonWidget, 'checkbox': inputWidget('click', modelFormattedAccessor, checkedAccessor, initWidgetValue(false)), 'radio': inputWidget('click', modelFormattedAccessor, radioAccessor, radioInit), 'select-one': inputWidget('change', modelAccessor, valueAccessor, initWidgetValue(null)), @@ -566,7 +561,7 @@ function inputWidgetSelector(element){ angularWidget('input', inputWidgetSelector); angularWidget('textarea', inputWidgetSelector); -angularWidget('button', inputWidgetSelector); + /** * @workInProgress -- cgit v1.2.3