From c4ef1f2fdd73bdaeda879e596d3d96e4e68cb6fd Mon Sep 17 00:00:00 2001 From: Misko Hevery Date: Thu, 8 Apr 2010 13:43:40 -0700 Subject: tests failing jstd to show cory --- src/widgets.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'src/widgets.js') diff --git a/src/widgets.js b/src/widgets.js index e89e8ca4..faa60043 100644 --- a/src/widgets.js +++ b/src/widgets.js @@ -22,16 +22,20 @@ function valueAccessor(scope, element) { var validatorName = element.attr('ng-validate') || NOOP, validator = compileValidator(validatorName), required = element.attr('ng-required'), - lastError, + lastError, lastVisible, invalidWidgets = scope.$invalidWidgets || {markValid:noop, markInvalid:noop}; required = required || required === ''; if (!validator) throw "Validator named '" + validatorName + "' not found."; function validate(value) { - var error = required && !trim(value) ? "Required" : validator({state:scope, scope:{get:scope.$get, set:scope.$set}}, value); - if (error !== lastError) { + var error = required && !trim(value) ? + "Required" : + validator({state:scope, scope:{get:scope.$get, set:scope.$set}}, value), + visible = isVisible(element); + if (error !== lastError || visible !== lastVisible) { elementError(element, NG_VALIDATION_ERROR, error); lastError = error; - if (error) + lastVisible = visible; + if (error && visible) invalidWidgets.markInvalid(element); else invalidWidgets.markValid(element); -- cgit v1.2.3