From f5d08963b0c836b10133a94d03a81254242661eb Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Tue, 25 Jan 2011 20:44:44 -0800 Subject: split mocks and create $log and $exceptionHandler mocks - split mocks between angular-mocks.js and mocks.js - src/angular-mocks.js now contains only mocks that we want to ship - test/mocks.js contains mocks that we use internally for testing angular - created angular.mock namespace - created public $exceptionHandler mock rethrows errors - created public $log mock stores all logs messages in an array that can be accessed to make assertions - internally we now have factory to create $exceptionHandler that we can assert on - internally we also keep track of all messages logged and fail tests if messages were not expected and cleaned up (checked via global beforeEach and afterEach) - updated RakeFile and docs reader.js to point to the new angular-mocks.js location - made real $exceptionHandler and $log factories accessible from tests and simplified their specs - fixed typos in several spec descriptions - added log assertions throughout the test suite --- src/services.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'src/services.js') diff --git a/src/services.js b/src/services.js index aa4a2090..7c4e7dfd 100644 --- a/src/services.js +++ b/src/services.js @@ -290,10 +290,10 @@ angularServiceInject("$location", function($browser) { * @requires $window * * @description - * Is simple service for logging. Default implementation writes the message + * Simple service for logging. Default implementation writes the message * into the browser's console (if present). * - * This is useful for debugging. + * The main purpose of this service is to simplify debugging and troubleshooting. * * @example

Reload this page with open console, enter text and hit the log button...

@@ -304,7 +304,8 @@ angularServiceInject("$location", function($browser) { */ -angularServiceInject("$log", function($window){ +var $logFactory; //reference to be used only in tests +angularServiceInject("$log", $logFactory = function($window){ return { /** * @workInProgress @@ -387,7 +388,8 @@ angularServiceInject("$log", function($window){ * * @example */ -angularServiceInject('$exceptionHandler', function($log){ +var $exceptionHandlerFactory; //reference to be used only in tests +angularServiceInject('$exceptionHandler', $exceptionHandlerFactory = function($log){ return function(e) { $log.error(e); }; -- cgit v1.2.3