From 76b628bcb3511210d312ed667e5c14d908a9fed1 Mon Sep 17 00:00:00 2001 From: Matias Niemelä Date: Wed, 23 Oct 2013 15:14:27 -0400 Subject: fix($animate): skip unnecessary addClass/removeClass animations Skip addClass animations if the element already contains the class that is being added to element. Also skip removeClass animations if the element does not contain the class that is being removed. Closes #4401 Closes #2332 --- src/ngAnimate/animate.js | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'src/ngAnimate') diff --git a/src/ngAnimate/animate.js b/src/ngAnimate/animate.js index 3c9ea9a9..838e210f 100644 --- a/src/ngAnimate/animate.js +++ b/src/ngAnimate/animate.js @@ -541,6 +541,16 @@ angular.module('ngAnimate', ['ng']) (ngAnimateState.done || noop)(); } + //There is no point in perform a class-based animation if the element already contains + //(on addClass) or doesn't contain (on removeClass) the className being animated. + //The reason why this is being called after the previous animations are cancelled + //is so that the CSS classes present on the element can be properly examined. + if((event == 'addClass' && element.hasClass(className)) || + (event == 'removeClass' && !element.hasClass(className))) { + onComplete && onComplete(); + return; + } + element.data(NG_ANIMATE_STATE, { running:true, structural:!isClassBased, -- cgit v1.2.3