From 8f46a3c9ac075c6300e974efaecd0d10d986a515 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Wed, 12 Oct 2011 00:10:20 -0700 Subject: fix(jqLite): attr for boolean attribute should lowercase value --- src/jqLite.js | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) (limited to 'src/jqLite.js') diff --git a/src/jqLite.js b/src/jqLite.js index e14eb127..816e1ba8 100644 --- a/src/jqLite.js +++ b/src/jqLite.js @@ -290,7 +290,7 @@ var JQLitePrototype = JQLite.prototype = { // value on get. ////////////////////////////////////////// var BOOLEAN_ATTR = {}; -forEach('multiple,selected,checked,disabled,readOnly,required'.split(','), function(value, key) { +forEach('multiple,selected,checked,disabled,readOnly,required'.split(','), function(value) { BOOLEAN_ATTR[lowercase(value)] = value; }); @@ -340,17 +340,22 @@ forEach({ }, attr: function(element, name, value){ - if (BOOLEAN_ATTR[name]) { + var lowercasedName = lowercase(name); + if (BOOLEAN_ATTR[lowercasedName]) { if (isDefined(value)) { if (!!value) { element[name] = true; - element.setAttribute(name, name); + element.setAttribute(name, lowercasedName); } else { element[name] = false; - element.removeAttribute(name); + element.removeAttribute(lowercasedName); } } else { - return (element[name] || element.getAttribute(name)) ? name : undefined; + return (element[name] || + element.getAttribute(name) !== null && + (msie < 9 ? element.getAttribute(name) !== '' : true)) + ? lowercasedName + : undefined; } } else if (isDefined(value)) { element.setAttribute(name, value); -- cgit v1.2.3