From 1169b5445691e1495354d235a3badf05240e3904 Mon Sep 17 00:00:00 2001 From: Hubert SABLONNIÈRE Date: Fri, 25 Oct 2013 21:52:49 +0200 Subject: fix(jqLite): ignore incompatible nodes on find() When a jqLite collection contains text nodes, find() does not work :-( This fix ignores all nodes than can't do getElementsByTagName() It seems a little bit faster than testing nodeType : http://jsperf.com/nodetype-vs-duck-typing Closes #4120 --- src/jqLite.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/jqLite.js') diff --git a/src/jqLite.js b/src/jqLite.js index 218efe24..e7531fb3 100644 --- a/src/jqLite.js +++ b/src/jqLite.js @@ -822,7 +822,11 @@ forEach({ }, find: function(element, selector) { - return element.getElementsByTagName(selector); + if (element.getElementsByTagName) { + return element.getElementsByTagName(selector); + } else { + return []; + } }, clone: jqLiteClone, -- cgit v1.2.3