From 0a6cf70debc6440685af3f9ea96a66450e4f4ed7 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Fri, 7 Jan 2011 22:02:23 -0800 Subject: Rename angular.foreach to angular.forEach to make the api consistent. camelcase is used for other angular functions and forEach is also used by EcmaScript standard. - rename the internal as well as the external function name - tweak the implementation of the function so that it doesn't clober it self when we extend the angular object with an object that has a forEach property equal to this forEach function Closes #85 --- src/jqLite.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/jqLite.js') diff --git a/src/jqLite.js b/src/jqLite.js index cbb2c7b8..a59ba6c2 100644 --- a/src/jqLite.js +++ b/src/jqLite.js @@ -18,7 +18,7 @@ function jqClearData(element) { var cacheId = element[jqName], cache = jqCache[cacheId]; if (cache) { - foreach(cache.bind || {}, function(fn, type){ + forEach(cache.bind || {}, function(fn, type){ removeEventListenerFn(element, type, fn); }); delete jqCache[cacheId]; @@ -106,7 +106,7 @@ JQLite.prototype = { bind = self.data('bind'), eventHandler; if (!bind) this.data('bind', bind = {}); - foreach(type.split(' '), function(type){ + forEach(type.split(' '), function(type){ eventHandler = bind[type]; if (!eventHandler) { bind[type] = eventHandler = function(event) { @@ -120,7 +120,7 @@ JQLite.prototype = { event.cancelBubble = true; //ie }; } - foreach(eventHandler.fns, function(fn){ + forEach(eventHandler.fns, function(fn){ fn.call(self, event); }); }; @@ -142,7 +142,7 @@ JQLite.prototype = { append: function(node) { var self = this[0]; node = jqLite(node); - foreach(node, function(child){ + forEach(node, function(child){ self.appendChild(child); }); }, @@ -200,7 +200,7 @@ JQLite.prototype = { attr: function(name, value){ var e = this[0]; if (isObject(name)) { - foreach(name, function(value, name){ + forEach(name, function(value, name){ e.setAttribute(name, value); }); } else if (isDefined(value)) { -- cgit v1.2.3