From 39312d1fe3a27b248f98f6f26577fcd7e2c64f85 Mon Sep 17 00:00:00 2001
From: Shyam Seshadri
Date: Wed, 2 Jun 2010 15:05:34 -0700
Subject: Revert "Revert "removed few key foreach and replaced thime with for
 loop for performance.""

This reverts commit a29c5e4c7fd5e708c28e70e974bf873621d5277c.
---
 src/directives.js | 51 ++++++++++++++++++++++++++++++---------------------
 1 file changed, 30 insertions(+), 21 deletions(-)

(limited to 'src/directives.js')

diff --git a/src/directives.js b/src/directives.js
index 91a98735..cabf0c23 100644
--- a/src/directives.js
+++ b/src/directives.js
@@ -24,14 +24,17 @@ angularDirective("ng-eval", function(expression){
 
 angularDirective("ng-bind", function(expression){
   return function(element) {
-    var lastValue, lastError;
+    var lastValue = noop, lastError = noop;
     this.$onEval(function() {
       var error,
           value = this.$tryEval(expression, function(e){
             error = toJson(e);
           }),
-          isHtml = value instanceof HTML,
-          isDomElement = isElement(value);
+          isHtml,
+          isDomElement;
+      if (lastValue === value && lastError == error) return;
+      isHtml = value instanceof HTML,
+      isDomElement = isElement(value);
       if (!isHtml && !isDomElement && isObject(value)) {
         value = toJson(value);
       }
@@ -72,14 +75,14 @@ function compileBindTemplate(template){
     });
     bindTemplateCache[template] = fn = function(element){
       var parts = [], self = this;
-      foreach(bindings, function(fn){
-        var value = fn.call(self, element);
+      for ( var i = 0; i < bindings.length; i++) {
+        var value = bindings[i].call(self, element);
         if (isElement(value))
           value = '';
         else if (isObject(value))
           value = toJson(value, true);
         parts.push(value);
-      });
+      };
       return parts.join('');
     };
   }
@@ -107,21 +110,26 @@ var REMOVE_ATTRIBUTES = {
 };
 angularDirective("ng-bind-attr", function(expression){
   return function(element){
+    var lastValue = {};
     this.$onEval(function(){
-      foreach(this.$eval(expression), function(bindExp, key) {
-        var value = compileBindTemplate(bindExp).call(this, element),
+      var values = this.$eval(expression);
+      for(var key in values) {
+        var value = compileBindTemplate(values[key]).call(this, element),
             specialName = REMOVE_ATTRIBUTES[lowercase(key)];
-        if (specialName) {
-          if (element[specialName] = toBoolean(value)) {
-            element.attr(specialName, value);
+        if (lastValue[key] !== value) {
+          lastValue[key] = value;
+          if (specialName) {
+            if (element[specialName] = toBoolean(value)) {
+              element.attr(specialName, value);
+            } else {
+              element.removeAttr(key);
+            }
+            (element.data('$validate')||noop)();
           } else {
-            element.removeAttr(key);
+            element.attr(key, value);
           }
-          (element.data('$validate')||noop)();
-        } else {
-          element.attr(key, value);
         }
-      }, this);
+      };
     }, element);
   };
 });
@@ -153,17 +161,18 @@ angularWidget("@ng-repeat", function(expression, element){
 
     var children = [], currentScope = this;
     this.$onEval(function(){
-      var index = 0, childCount = children.length, childScope, lastElement = reference;
-      foreach(this.$tryEval(rhs, reference), function(value, key){
+      var index = 0, childCount = children.length, childScope, lastElement = reference,
+          collection = this.$tryEval(rhs, reference);
+      for ( var key in collection) {
         if (index < childCount) {
           // reuse existing child
           childScope = children[index];
-          childScope[valueIdent] = value;
+          childScope[valueIdent] = collection[key];
           if (keyIdent) childScope[keyIdent] = key;
         } else {
           // grow children
           childScope = template(element.clone(), createScope(currentScope));
-          childScope[valueIdent] = value;
+          childScope[valueIdent] = collection[key];
           if (keyIdent) childScope[keyIdent] = key;
           lastElement.after(childScope.$element);
           childScope.$index = index;
@@ -174,7 +183,7 @@ angularWidget("@ng-repeat", function(expression, element){
         childScope.$eval();
         lastElement = childScope.$element;
         index ++;
-      });
+      };
       // shrink children
       while(children.length > index) {
         children.pop().$element.remove();
-- 
cgit v1.2.3